Remove solution folders correctly #1468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @RyanCavanaugh, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
paulvanbrenk
approved these changes
Jan 31, 2017
| // When we don't call this it behaves properly also in Solution Explorer search result set | ||
| // Notify hierarchy event listeners that items have been invalidated | ||
| //ProjectMgr.OnInvalidateItems(this); | ||
| ProjectMgr.OnInvalidateItems(this); |
Contributor
There was a problem hiding this comment.
Is this change required, can you update the comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal bug 374959
Create a Node.js app from the Basic Node.js Express 4 Application.
Add a new folder to the solution.
Add a new TypeScript file to the folder.
Enter some code.
Compile.
Delete the folder.
Compile.
Expected: compilation succeeds.
Actual:
Severity Code Description Project File Line Suppression State
Error Build:File 'C:/Users/USER/documents/visual studio 2017/Projects/ExpressApp1/ExpressApp1/stuff/stuff.ts' not found. ExpressApp1 tsc 0
The project file still contains this after deleting the folder: