#455 IntelliSense commits too aggressively when completion is selected #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s selected - do not enable COMPLETEWORD when OnlyTabOrEnterToCommit option is enabled
Member
|
So this just causes it to show the list even if only one member? (I noticed this, but didn't think it was a big deal). 👍 if that's the only behavior change. |
Contributor
Author
|
Yep, that's the only behavior change - it's a bigger deal when IntelliSense is being automatically displayed because typing "const" automatically completes it to "constructor" since "const" isn't in the list and there's only one item selected. |
mousetraps
added a commit
that referenced
this pull request
Sep 16, 2015
fix #455 IntelliSense commits too aggressively when completion is selected
Contributor
Author
|
Gah, sorry I conflated two examples. The const thing applied only to one of the unit tests where ctrl+space was used to grab the completions list since spaces don't actually cause use to commit. But the user-facing issue was when assigning to a variable that didn't exist in isense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabled
fix #455