Lowercase and trim npm package names for templates#706
Merged
mousetraps merged 4 commits intomicrosoft:masterfrom Feb 26, 2016
Merged
Lowercase and trim npm package names for templates#706mousetraps merged 4 commits intomicrosoft:masterfrom
mousetraps merged 4 commits intomicrosoft:masterfrom
Conversation
Adds a little extra normalization when converting a VS project names to npm project names in the templates: * Lowercase names. Inserts hypens between camelcased strings: "ExpressApp4" -> "express-app-4" * Trim to name to 214 characters closes microsoft#705
|
Hi @mjbvz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
|
||
| // Remove all leading url-invalid, underscore, and period characters from the string | ||
| /// <summary> | ||
| /// Normalize a project name to be a valid Npm package name. |
Contributor
There was a problem hiding this comment.
Could you include a link to the docs on valid package names in the comment here?
https://docs.npmjs.com/files/package.json#name
Contributor
|
minor comments, and 👍 after that! |
Small fix to spelling and reordering to put private methods last based on review comments.
mousetraps
added a commit
that referenced
this pull request
Feb 26, 2016
Lowercase and trim npm package names for templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a little extra normalization when converting a VS project names to npm project names when generating the
package.jsonfor the templates:closes #705