Fix Repl window null deref when main NTVS package has not been loaded yet #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… yet **Bug** If the Repl window is used before the main NTVS package has been loaded, `NodeJsPacakge.Instance` will be null. This causes a null deref problem **Fix** Add a few null checks. closes microsoft#917
Contributor
Author
|
Actually, the change should not hurt anything, but it also does not solve a normal use case bug. During development, I was messing around with the Repl window and this ended up persisting some bad data about the Repl Window to the registry under the |
| public static IWpfTextView GetActiveTextView(System.IServiceProvider serviceProvider) { | ||
| if (serviceProvider == null) { | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
for both null checks, it's okay to fail gracefully, but let's go ahead and also add a debug assert so we know something's up when the issue occurs.
Contributor
|
minor comment and 👍 after that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#917
Bug
If the Repl window is used before the main NTVS package has been loaded,
NodeJsPacakge.Instancewill be null. This causes a null deref problem in some call paths (see #917)Fix
Add a few null checks to these call paths.
closes #917