Tracelog lib: missing switch cases for KEYWORD_PROCESS#317
Merged
kumarvin123 merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
kumarvin123
requested review from
Alan-Jowett,
LakshK98,
matthewige,
mikeagun,
mtfriesen,
poornagmsft,
saxena-anurag and
shankarseal
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes missing TraceLogging keyword handling for process-related events in the eBPF extension tracelog helper, ensuring EBPF_EXT_TRACELOG_KEYWORD_PROCESS is correctly routed through existing logging switch macros.
Changes:
- Add
CASE_PROCESSbranches to multiple keyword switch macros so process keyword logs are emitted for NTSTATUS failures and message/value logging. - Minor formatting consistency adjustments in the tracelog implementation (per PR description).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LakshK98
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix addressing missing switch cases for KEYWORD_PROCESS in the tracelog library.
#FIXES #63
PR Summary
This pull request updates the tracelog library by adding the missing CASE_PROCESS entries to various logging switch statements, ensuring proper handling of process-related events.
libs/ebpf_ext/ebpf_ext_tracelog.c: Added CASE_PROCESS cases in functions handling NT status failures, message strings, and numeric logging.
libs/ebpf_ext/ebpf_ext_tracelog.c: Tweaked function declaration formatting for consistency.
Describe the purpose of and changes within this Pull Request.
Testing
Do any existing tests cover this change? Are new tests needed?
Existing CI/CD tests
Documentation
Is there any documentation impact for this change?
No
Installation
No
Is there any installer impact for this change?