Skip to content

Conversation

@elopezanaya
Copy link
Contributor

@elopezanaya elopezanaya commented May 4, 2025

PR Details

Thank you for your contribution. Before submitting this PR, please include:

Id of the task, bug, story or other reference

Description

We allow calls even unders scenarios set to fail, like offline devices or expired tokens

we need to find a way to prevent those scenarios

Include a description of the problem to be solved

Solution Proposed

Use of decorator pattern to wrap function in a non-invasive way,

The gatekeeper will intercept the call and then evalute the condition, this can be extended to additional business rules,

only if those conditions are meet the call will be performed, otherwise we inform the caller to adjust due to the current state

image

Detail what is the solution proposed, include links to design document if required or any other document required to support the solution

Acceptance criteria

Define what are the conditions to consider the PR has achieved the intended goal

Test cases and evidence

offline situation midway during the conversation

loads and get messages while online

image

offfline is detected

image

online recovered

image

Include what tests cases were considered, any evidence of testing for future references, to identify any corner cases, etc

Sanity Tests

  • You have tested all changes in Popout mode
  • You have tested all changes in cross browsers i.e Edge, Chrome, Firefox, Safari and mobile devices(iOS and Android)
  • Your changes are included in the CHANGELOG

A11y

Please provide justification if any of the validations has been skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant