Skip to content

Conversation

@elopezanaya
Copy link
Contributor

PR Details

Thank you for your contribution. Before submitting this PR, please include:

Id of the task, bug, story or other reference

Description

Include a description of the problem to be solved

Solution Proposed

Detail what is the solution proposed, include links to design document if required or any other document required to support the solution

Acceptance criteria

Define what are the conditions to consider the PR has achieved the intended goal

Test cases and evidence

Include what tests cases were considered, any evidence of testing for future references, to identify any corner cases, etc

image

Sanity Tests

  • You have tested all changes in Popout mode
  • You have tested all changes in cross browsers i.e Edge, Chrome, Firefox, Safari and mobile devices(iOS and Android)
  • Your changes are included in the CHANGELOG

A11y

Please provide justification if any of the validations has been skipped.

@elopezanaya elopezanaya marked this pull request as ready for review May 16, 2025 01:24
Copy link
Contributor

@xTEddie xTEddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this for the moment. I see a “react-native” package as peer dependency. It means that this package needs to be installed as part of installing chat-sdk. This package is not needed on building apps on “web”. It would possibly break scenarios on web due to this package not being installed on web projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants