Skip to content

Conversation

@natke
Copy link
Contributor

@natke natke commented Jun 3, 2022

No description provided.

Copy link

@KevinH48264 KevinH48264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@natke
Copy link
Contributor Author

natke commented Jun 10, 2022

Anyone know why the CI is failing? @snnn @edgchen1

 Traceback (most recent call last):
2022-06-03T18:51:34.4150440Z   File "/Users/runner/work/1/s/mobile/examples/basic_usage/model/single_add_gen.py", line 1, in <module>
2022-06-03T18:51:34.4214450Z     import onnx
2022-06-03T18:51:34.4246740Z   File "/Users/runner/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/onnx/__init__.py", line 11, in <module>
2022-06-03T18:51:34.4266000Z     from onnx.external_data_helper import load_external_data_for_model, write_external_data_tensors, convert_model_to_external_data
2022-06-03T18:51:34.4304670Z   File "/Users/runner/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/onnx/external_data_helper.py", line 14, in <module>
2022-06-03T18:51:34.4410450Z     from .onnx_pb import TensorProto, ModelProto
2022-06-03T18:51:34.4511130Z   File "/Users/runner/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/onnx/onnx_pb.py", line 8, in <module>
2022-06-03T18:51:34.4563450Z     from .onnx_ml_pb2 import *  # noqa
2022-06-03T18:51:34.4665740Z   File "/Users/runner/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/onnx/onnx_ml_pb2.py", line 37, in <module>
2022-06-03T18:51:34.4760450Z     create_key=_descriptor._internal_create_key),
2022-06-03T18:51:34.4815600Z   File "/Users/runner/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/google/protobuf/descriptor.py", line 755, in __new__
2022-06-03T18:51:34.4844640Z     _message.Message._CheckCalledFromGeneratedFile()
2022-06-03T18:51:34.4855810Z TypeError: Descriptors cannot not be created directly.
2022-06-03T18:51:34.4879600Z If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
2022-06-03T18:51:34.4908350Z If you cannot immediately regenerate your protos, some other possible workarounds are:
2022-06-03T18:51:34.4917580Z  1. Downgrade the protobuf package to 3.20.x or lower.
2022-06-03T18:51:34.4927720Z  2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

@edgchen1
Copy link
Contributor

edgchen1 commented Jun 10, 2022

Looks like this is the issue: onnx/onnx#4222
ONNX didn't specify an upper bound for the version of its Protobuf dependency before and there was a breaking change in a new Protobuf version.

#119 should address it.

@natke natke requested a review from edgchen1 June 11, 2022 03:54
@natke natke merged commit ce575e3 into main Jun 27, 2022
@natke natke deleted the natke-patch-1 branch June 27, 2022 20:53
shamaksx pushed a commit to intel/onnxruntime-inference-examples that referenced this pull request Sep 28, 2022
jywu-msft pushed a commit that referenced this pull request Oct 27, 2022
* bug fix in OVEP csharp sample

* Samples updated

* cpp sample update

* Improve the SNPE EP sample with command line option to switch SNPE backend (#120)

* Improve the sample with command line option to switch SNPE backend, and set the input file path.
Fix an issue for Android build, need to use libc++_shared.so from SNPE SDK.

* 1. Update the API call according the API change in Ort, SessionOptionsAppendExecutionProvider_SNPE -> SessionOptionsAppendExecutionProvider
2. format update

* Add table of contents to Python samples (#115)

* update doc for Snpe EP to reflect the API change (#122)

* update doc for snpe to reflect the API change

* Set default format to QuantFormat.QDQ (#123)

* Add MAUI example for mobile targets (#128)

* Add short term workaround to issue with iOS publish where the CoreML frameworks is not added to the link list. Pending real fix from MAUI folks. (#131)

Also update ORT to 1.12.1 which has a better Android build.

* Quantization tool example bug fix (#133)

In ResNet50DataReader, it uses an onnx session to obtain the model input shape. However it passes a madeup model name to the onnx session, resulting in file not found error.

This change provide the original float model path to the data reader

* sample notebooks for yolov4 and tiny-yoloV2 (#136)

* sample notebooks for yolov4 and tiny-yoloV2

* folder restucturing for notebooks

* folder restucturing for notebooks

Co-authored-by: krishnendukx <krishnendux.kar@intel.com>
Co-authored-by: krishnendukx <111554749+krishnendukx@users.noreply.github.com>

* Update MauiVisionSample SkiaSharp dependency version to 2.88.1. (#135)

Includes this fix in SkiaSharp: mono/SkiaSharp#2198

* add qdq debugging example (#134)

Adding example run_qdq_debug.py

* Adding quantization example for gpt-2 medium (#140)

add gpt2 qdq example

* Remove deprecated API usage (#144)

Co-authored-by: nmaajidk <n.maajid.khan@intel.com>
Co-authored-by: Hector Li <hecli@microsoft.com>
Co-authored-by: Nat Kershaw (MSFT) <nakersha@microsoft.com>
Co-authored-by: Yufeng Li <liyufeng1987@gmail.com>
Co-authored-by: Scott McKay <skottmckay@gmail.com>
Co-authored-by: Chen Fu <1316708+chenfucn@users.noreply.github.com>
Co-authored-by: sfatimar <sahar.fatima@intel.com>
Co-authored-by: krishnendukx <krishnendux.kar@intel.com>
Co-authored-by: krishnendukx <111554749+krishnendukx@users.noreply.github.com>
Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
Co-authored-by: Dmitri Smirnov <yuslepukhin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants