Skip to content

Conversation

@chenfucn
Copy link
Contributor

Adding example run_qdq_debug.py

@chenfucn chenfucn requested a review from yufenglee August 19, 2022 19:13
@chenfucn chenfucn force-pushed the cfu_qdqbugfix branch 2 times, most recently from 3b29028 to 224c2d5 Compare August 25, 2022 17:22
dr = resnet50_data_reader.ResNet50DataReader(
calibration_dataset_path, input_model_path
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call the pre-precess?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would break the flow described in Readme.md if we call pre-processing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better to make the pre-processing front and center. In the example, highlighting it to be a separated step. If I call it in her, it is kinda hidden. The user must dig into python code to locate it. In current layout, this step is on the command line level instead of python code level. This might be more obvious to the user. What do you think?

@chenfucn
Copy link
Contributor Author

rebased on the main

@chenfucn chenfucn merged commit 4fa5b14 into main Sep 1, 2022
@chenfucn chenfucn deleted the cfu_qdqbugfix branch September 1, 2022 18:10
shamaksx pushed a commit to intel/onnxruntime-inference-examples that referenced this pull request Sep 28, 2022
Adding example run_qdq_debug.py
jywu-msft pushed a commit that referenced this pull request Oct 27, 2022
* bug fix in OVEP csharp sample

* Samples updated

* cpp sample update

* Improve the SNPE EP sample with command line option to switch SNPE backend (#120)

* Improve the sample with command line option to switch SNPE backend, and set the input file path.
Fix an issue for Android build, need to use libc++_shared.so from SNPE SDK.

* 1. Update the API call according the API change in Ort, SessionOptionsAppendExecutionProvider_SNPE -> SessionOptionsAppendExecutionProvider
2. format update

* Add table of contents to Python samples (#115)

* update doc for Snpe EP to reflect the API change (#122)

* update doc for snpe to reflect the API change

* Set default format to QuantFormat.QDQ (#123)

* Add MAUI example for mobile targets (#128)

* Add short term workaround to issue with iOS publish where the CoreML frameworks is not added to the link list. Pending real fix from MAUI folks. (#131)

Also update ORT to 1.12.1 which has a better Android build.

* Quantization tool example bug fix (#133)

In ResNet50DataReader, it uses an onnx session to obtain the model input shape. However it passes a madeup model name to the onnx session, resulting in file not found error.

This change provide the original float model path to the data reader

* sample notebooks for yolov4 and tiny-yoloV2 (#136)

* sample notebooks for yolov4 and tiny-yoloV2

* folder restucturing for notebooks

* folder restucturing for notebooks

Co-authored-by: krishnendukx <krishnendux.kar@intel.com>
Co-authored-by: krishnendukx <111554749+krishnendukx@users.noreply.github.com>

* Update MauiVisionSample SkiaSharp dependency version to 2.88.1. (#135)

Includes this fix in SkiaSharp: mono/SkiaSharp#2198

* add qdq debugging example (#134)

Adding example run_qdq_debug.py

* Adding quantization example for gpt-2 medium (#140)

add gpt2 qdq example

* Remove deprecated API usage (#144)

Co-authored-by: nmaajidk <n.maajid.khan@intel.com>
Co-authored-by: Hector Li <hecli@microsoft.com>
Co-authored-by: Nat Kershaw (MSFT) <nakersha@microsoft.com>
Co-authored-by: Yufeng Li <liyufeng1987@gmail.com>
Co-authored-by: Scott McKay <skottmckay@gmail.com>
Co-authored-by: Chen Fu <1316708+chenfucn@users.noreply.github.com>
Co-authored-by: sfatimar <sahar.fatima@intel.com>
Co-authored-by: krishnendukx <krishnendux.kar@intel.com>
Co-authored-by: krishnendukx <111554749+krishnendukx@users.noreply.github.com>
Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
Co-authored-by: Dmitri Smirnov <yuslepukhin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants