Add support for FusedAdam to be mathematically equivalent to pytorch/AdamW#10106
Merged
Conversation
baijumeswani
requested review from
SherlockNoMad,
liqunfu,
thiagocrepaldi,
tlh20 and
xadupre
as code owners
baijumeswani
added
training
xadupre
reviewed
Jan 10, 2022
xadupre
reviewed
Jan 10, 2022
xadupre
reviewed
Jan 10, 2022
…o bmeswani/update_fused_adam
ytaous
approved these changes
Jan 20, 2022
SherlockNoMad
approved these changes
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ORT's
FusedAdamis currently mathematically equivalent totransformers/AdamW. Users wanting to work withpytorch/AdamWmathematical implementation would see convergence disparity because of the subtle differences.This pull request introduces a way for users to select the implementation they want so that they can get the performance gains, as well as aligned convergence.