Skip to content

Update DirectML EP for ORT 1.11#10619

Merged
fdwr merged 17 commits into
masterfrom
user/dwayner/DmlDev20220221
Feb 23, 2022
Merged

Update DirectML EP for ORT 1.11#10619
fdwr merged 17 commits into
masterfrom
user/dwayner/DmlDev20220221

Conversation

@fdwr
Copy link
Copy Markdown
Contributor

@fdwr fdwr commented Feb 22, 2022

Description:

  • Includes RI from WindowsAI DmlDev.
  • Registers additional operators for ONNX opset 13:
    • DequantizeLinear-13 & QuantizeLinear-13 axis attribute
    • ReduceSum-13 with noop_with_empty_axes attribute
    • Split-13, Squeeze-13, Unsqueeze-13, ReduceSum-13 axes now tensor input
  • No changes to DirectML.dll version this time.

Motivation and Context

  • Why is this change required? Features, bug fixes

jstoecker and others added 16 commits December 2, 2021 10:32
Successful build: https://microsoft.visualstudio.com/WindowsAI/_build/results?buildId=42253044&view=logs&j=4e3dd845-80f6-5682-7592-d2eda4c1196a&t=b3ed071a-d172-5351-0dfc-02424ddb17a7

```
Printing log to show merge was successful.
1bbf04e75564b074a4c5a6fc051a357882fb2c76 Merge remote-tracking branch 'upstream/master' into dmldev_temp
3f5c1e1 Update to include the Xamarin targets for internal ORT builds so the managed nuget package is consistent as both CPU and GPU builds produce a package called Microsoft.ML.OnnxRuntime.Managed. (#9906)
```
Related work items: #37712737
Related work items: #37239556
Related work items: #37712737
Just RI.

Related work items: #38034064
Extend opset 13 support for:
- Split-13
- Squeeze-13
- Unsqueeze-13
- Reshape-13
- QuantizeLinear-13
- DequantizeLinear-13
- ReduceSum-13
- Resize-13

Also:
- Rename the file where all the opset versions are stored from "OperatorRegistration.h" to "OperatorVersions.h", which will make it much less confusing in the future when looking given there's another file called "OperatorRegistration.h" that corresponds to "OperatorRegistration.cpp".
- Detemplatize many of the OperatorHelper.h constructors, which duplicate multiple instantiations due to the operator helper classes not sharing a common base class, by wrapping them with an adapter. Ideally there would be a common COM base interface that both IMLOperatorKernelCreationContext and IMLOperatorShapeInferenceContext implementation objects would implement, which a wrapper in MLOperatorAuthorHelper.h could QI for.
- Fix style formatting issues in OperatorHelper.h (sorry for the noise).

```
Summary: Total=4679, Passed=4355, Failed=0, Blocked=0, Not Run=0, Skipped=324
```

Corresponding WindowsAI PR:
https://microsoft.visualstudio.com/WindowsAI/_git/WindowsAI/pullrequest/6973645

Related work items: #36672908, #36672926
@fdwr fdwr requested a review from sumitsays February 22, 2022 04:05
Copy link
Copy Markdown
Contributor

@sumitsays sumitsays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have already been reviewed as it is just a RI PR from DmlDev to github ORT master,

@fdwr fdwr merged commit ea7f773 into master Feb 23, 2022
@fdwr fdwr deleted the user/dwayner/DmlDev20220221 branch February 23, 2022 09:09
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
…20220221

Update DirectML EP for ORT 1.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants