Add function body for SoftmaxCrossEntropyLossGrad#10779
Merged
gramalingam merged 21 commits intomasterfrom Apr 5, 2022
Merged
Conversation
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
aaronsm
reviewed
Mar 5, 2022
edgchen1
reviewed
Mar 7, 2022
edgchen1
reviewed
Mar 7, 2022
codemzs
reviewed
Mar 7, 2022
| // label : [B, d1, d2, ...] | ||
|
|
||
| // We decompose the forward propagation into two steps, for doing the backward prop. | ||
| // Step 1: loss = Neg(Logsoftmax(prediction-for-true-label)) |
Member
Member
The node we see in the graph is SoftmaxCrossEntropyLossInternalGrad, do we need to make this change there as well? Same for SoftmaxCrossEntropyLossInternal Refers to: orttraining/orttraining/core/graph/training_op_defs.cc:1419 in 0cfa560. [](commit_id = 0cfa560, deletion_comment = False) |
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com@orttrainingdev7.d32nl1ml4oruzj4qz3bqlggovf.px.internal.cloudapp.net>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com@orttrainingdev7.d32nl1ml4oruzj4qz3bqlggovf.px.internal.cloudapp.net>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com@orttrainingdev7.d32nl1ml4oruzj4qz3bqlggovf.px.internal.cloudapp.net>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Contributor
|
/azp run Linux GPU TensorRT CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
codemzs
reviewed
Mar 16, 2022
codemzs
reviewed
Mar 16, 2022
souptc
previously approved these changes
Mar 16, 2022
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
souptc
approved these changes
Apr 5, 2022
seddonm1
pushed a commit
to seddonm1/onnxruntime
that referenced
this pull request
May 15, 2022
* Add function definition for SoftmaxCrossEntropyLossGrad Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Cleanup Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Eliminate unused variable Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix index of weight tensor Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * A few fixes to handle typing and weight Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix for zero D dimensions Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add function body to internal op also Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * A few fixes Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix type variable name Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix type constraint var Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix ignore_index handling in testcase Signed-off-by: Ganesan Ramalingam <grama@microsoft.com@orttrainingdev7.d32nl1ml4oruzj4qz3bqlggovf.px.internal.cloudapp.net> * Add fun def for SoftmaxCrossEntropyLossInternal Signed-off-by: Ganesan Ramalingam <grama@microsoft.com@orttrainingdev7.d32nl1ml4oruzj4qz3bqlggovf.px.internal.cloudapp.net> * Specify opset Signed-off-by: Ganesan Ramalingam <grama@microsoft.com@orttrainingdev7.d32nl1ml4oruzj4qz3bqlggovf.px.internal.cloudapp.net> * Handle opset in NLL function Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Modify onehot Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Eliminate duplicate statement Co-authored-by: Ganesan Ramalingam <grama@microsoft.com@orttrainingdev7.d32nl1ml4oruzj4qz3bqlggovf.px.internal.cloudapp.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add function body for SoftmaxCrossEntropyLossGrad