Small update to GraphLoadedFromModelFile check#1083
Merged
skottmckay merged 2 commits intoSep 11, 2019
Merged
Conversation
…puts) or value infos (e.g. a subgraph with just an If node in it). It should always have outputs but in case it doesn't (nothing fails currently if it doesn't even though that makes it meaningless) make sure it also has a node.
linkerzhang
approved these changes
May 27, 2019
yuslepukhin
deleted the
skottmckay/TweakCheckOnWhetherGraphInstanceWasLoadedFromFile
branch
yuslepukhin
restored the
skottmckay/TweakCheckOnWhetherGraphInstanceWasLoadedFromFile
branch
skottmckay
deleted the
skottmckay/TweakCheckOnWhetherGraphInstanceWasLoadedFromFile
branch
yuslepukhin
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Describe your changes - `ExtractAdapters` pass supports int4 quantized models. - Previously output models were always saved with external data. External data config options are exposed to the user. - `export_adapters` script also supports quantizing the weights to int4. ## Checklist before requesting a review - [x] Add unit tests for this change. - [x] Make sure all tests can pass. - [ ] Update documents if necessary. - [x] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A subgraph may have no inputs (e.g. subgraph in If has no explicit inputs) or value infos (e.g. a subgraph with just an If node in it).
It should always have outputs but in case it doesn't (nothing fails currently if it doesn't even though that makes it meaningless) make sure it has a node if there are no outputs.