Skip to content

[cmake] Add keyword STATIC to add_library in function onnxruntime_add_static_library#10998

Merged
snnn merged 1 commit into
microsoft:masterfrom
JackBoosY:dev/jack/add-static-keyword
Mar 25, 2022
Merged

[cmake] Add keyword STATIC to add_library in function onnxruntime_add_static_library#10998
snnn merged 1 commit into
microsoft:masterfrom
JackBoosY:dev/jack/add-static-keyword

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

Description: Describe your changes.
Add STATIC to avoid making shared library when BUILD_SHARED_LIBS is ON.

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

cc @snnn

@snnn
Copy link
Copy Markdown
Contributor

snnn commented Mar 25, 2022

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows CPU CI Pipeline

@snnn
Copy link
Copy Markdown
Contributor

snnn commented Mar 25, 2022

/azp run Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, onnxruntime-python-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 9 pipeline(s).

@snnn
Copy link
Copy Markdown
Contributor

snnn commented Mar 25, 2022

/azp run Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, onnxruntime-python-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 7 pipeline(s).

@snnn snnn merged commit d1be71e into microsoft:master Mar 25, 2022
@snnn
Copy link
Copy Markdown
Contributor

snnn commented Mar 25, 2022

Thank you!

@JackBoosY JackBoosY deleted the dev/jack/add-static-keyword branch March 28, 2022 01:58
lavanyax pushed a commit to intel/onnxruntime that referenced this pull request Mar 29, 2022
seddonm1 pushed a commit to seddonm1/onnxruntime that referenced this pull request May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants