EP factory creation cleanup and enhancements.#11798
Merged
skottmckay merged 10 commits intomasterfrom Jun 15, 2022
Merged
Conversation
…ction declarations in multiple places. Convert append EP for SNPE to be generic, and also use for XNNPACK. Add XNNPACK to C# API
HectorSVC
reviewed
Jun 9, 2022
Fix some more files with cut-and-pasted function signatures.
skottmckay
commented
Jun 10, 2022
| test.AddOutput<float>("output", {4, 2}, | ||
| {11.0f, 12.0f, 13.0f, 14.0f, | ||
| 21.0f, 22.0f, 23.0f, 24.0f}); | ||
| test.Run(); |
Contributor
Author
There was a problem hiding this comment.
clang-format doesn't join this into a single line if the opening '{' is on a new line.
… are built as separate libraries.
Only use EPs that require the layout transform if the opset is supported by the layout transformer.
…yCreationCleanup_AddGenericAppendEP_AddXnnpackToApis
pranavsharma
previously approved these changes
Jun 15, 2022
pranavsharma
approved these changes
Jun 15, 2022
skottmckay
deleted the
skottmckay/EPFactoryCreationCleanup_AddGenericAppendEP_AddXnnpackToApis
branch
mayeut
added a commit
to mayeut/onnxruntime
that referenced
this pull request
Jun 17, 2023
microsoft#11798 removed the include/core/providers/xnnpack folder, it shall not be installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rework the EP factory creation setup so we're not cut-and-pasting function declarations in multiple places.
Convert append EP for SNPE to be generic, and also use for XNNPACK.
Add XNNPACK to C# API
Motivation and Context
Initially adding xnnpack support...
Remove cut-and-pasting of EP factory creation funcs and make it easier to find where they're declared and implemented.