Conversation
tianleiwu
reviewed
Jun 17, 2022
Contributor
|
Is there a way to generalize the fusion for element-wise operator, like |
Contributor
|
Wouldn't the Cast Propagation feature (#7454) that Satya implemented already covers this case? |
Contributor
Author
Right. Previously I just want to enabled this for CUDA only, but the PropagateCastOps cannot do this. But on second thought, we don't have MLFloat16 kernel for CPU for Gelu/GeluGrad, it's safe to use PropagateCastOps. I've changed the code to use PropagateCastOps by promoting Gelu from Level2 Ops to Level1, which also solves this issue. |
tianleiwu
approved these changes
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some mix-precision models will cast data to float before Gelu and cast back to half after. This PR changes the Gelu and GeluGrad CUDA kernel to use float for compute internally, and remove these Cast nodes from graph on CUDA EP.