Container and memory allocation guidelines#12387
Merged
Merged
Conversation
yuslepukhin
requested review from
RyanUnderhill,
askhade,
pranavsharma and
skottmckay
edgchen1
reviewed
Aug 1, 2022
edgchen1
reviewed
Aug 2, 2022
edgchen1
reviewed
Aug 3, 2022
| // Use | ||
| void foo(gsl::span<const Node* const>); | ||
| ``` | ||
| * Prefer returning `gsl::span<const T>` by value instead of a const reference to a contiguous member container. Prefer returning `gsl::span` instead of a pointer referring to a chunk of memory. The size is also included in the span. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Prefer returning `gsl::span<const T>` by value instead of a const reference to a contiguous member container. Prefer returning `gsl::span` instead of a pointer referring to a chunk of memory. The size is also included in the span. | |
| * Prefer returning `gsl::span<const T>` by value instead of a const reference to a contiguous member container. Prefer returning `gsl::span` instead of a pointer referring to a chunk of memory as the size is also included in the span. |
as suggested by @skottmckay
edgchen1
approved these changes
Aug 3, 2022
Contributor
edgchen1
left a comment
edgchen1
left a comment
There was a problem hiding this comment.
looks good to me, perhaps have others review too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Update and move to a separate section guideline for containers that are memory efficient.
Motivation and Context
This is to promote awareness of the updated coding requirements.