Skip to content

[rn] Support UINT8 type for onnxruntime-react-native on iOS #13210

Merged
YUNQIUGUO merged 6 commits intomainfrom
yguo/uint8-react-native-ios-support
Oct 6, 2022
Merged

[rn] Support UINT8 type for onnxruntime-react-native on iOS #13210
YUNQIUGUO merged 6 commits intomainfrom
yguo/uint8-react-native-ios-support

Conversation

@YUNQIUGUO
Copy link
Copy Markdown
Contributor

Description

As title.

Motivation and Context

Uint8 type might be required for some model used in sample application.
To match supported data types for onnxruntime-react-native for Android.

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

skottmckay
skottmckay previously approved these changes Oct 4, 2022
Copy link
Copy Markdown
Contributor

@skottmckay skottmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

fs-eire
fs-eire previously approved these changes Oct 4, 2022
@edgchen1
Copy link
Copy Markdown
Contributor

edgchen1 commented Oct 4, 2022

FYI, I think ONNX Runtime Web CI Pipeline is complaining about code formatting in js/react_native/ios/OnnxruntimeModuleTest/TensorHelperTest.mm

@YUNQIUGUO
Copy link
Copy Markdown
Contributor Author

FYI, I think ONNX Runtime Web CI Pipeline is complaining about code formatting in js/react_native/ios/OnnxruntimeModuleTest/TensorHelperTest.mm

Yes. I noticed that too. will address the format issue.

@YUNQIUGUO YUNQIUGUO dismissed stale reviews from fs-eire and skottmckay via f835efe October 5, 2022 15:34
@YUNQIUGUO YUNQIUGUO merged commit 814e5cf into main Oct 6, 2022
@YUNQIUGUO YUNQIUGUO deleted the yguo/uint8-react-native-ios-support branch October 6, 2022 18:35
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
…t#13210)

### Description
<!-- Describe your changes. -->

As title.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

Uint8 type might be required for some model used in sample application.
To match supported data types for onnxruntime-react-native for Android.

Co-authored-by: rachguo <rachguo@rachguos-Mac-mini.local>
Co-authored-by: rachguo <rachguo@rachguos-Mini.attlocal.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants