Update pylint config to include valid short names#13631
Merged
justinchuby merged 1 commit intomainfrom Nov 14, 2022
Merged
Conversation
Also disabled `too-many-arguments` and `too-many-locals`
edgchen1
reviewed
Nov 14, 2022
|
|
||
| [tool.pylint.BASIC] | ||
| good-names = [ | ||
| "a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", |
Contributor
Author
There was a problem hiding this comment.
Good question :D Are there examples when o is used as a good name? I couldn't think of any when I was compiling the list
Contributor
There was a problem hiding this comment.
I don't use one letter variable names very often. it's just that every other letter is there, so I was wondering about the omission.
Contributor
Author
There was a problem hiding this comment.
I could have added a comment but the ci would then have to run for another half day. I will merge this and add some explanation when I work on linting later.
edgchen1
approved these changes
Nov 14, 2022
simon-moo
pushed a commit
to simon-moo/onnxruntime
that referenced
this pull request
Dec 21, 2022
### Description Update pylint config to include valid short names Also disabled `too-many-arguments` and `too-many-locals` ### Motivation and Context Refine config to reduce lint noise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update pylint config to include valid short names
Also disabled
too-many-argumentsandtoo-many-localsMotivation and Context
Refine config to reduce lint noise