Patch Protobuf and ONNX's cmake files and enforce BinSkim check#13694
Merged
Conversation
snnn
commented
Nov 18, 2022
| msBuildCommandline: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\amd64\msbuild.exe" "$(Build.BinariesDirectory)\Debug\onnxruntime.sln" /p:platform="$(MsbuildPlatform)" /p:configuration=Debug /p:VisualStudioVersion="16.0" /m /p:PreferredToolArchitecture=x64' | ||
| excludedPaths: '$(Build.BinariesDirectory)#$(Build.SourcesDirectory)\cmake#C:\program files (x86)' | ||
|
|
||
| - task: PostAnalysis@2 |
Contributor
Author
There was a problem hiding this comment.
This is the main change I want to add. All others are for making this task pass.
jchen351
approved these changes
Nov 18, 2022
snnn
pushed a commit
that referenced
this pull request
Nov 22, 2022
… source on MacOS (#13720) ### Description Add '-DCMAKE_OSX_ARCHITECTURES=x86_64;arm64' when build protobuf from source on MacOS. Because later on we will the built library with the other parts of onnxruntime to generate libonnxruntime.dylib, and if the target CPU ARCH of libonnxruntime.dylib is not x86_64, it will fail. ### Motivation and Context To fix a packaging pipeline failure, which was introduced from #13694
simon-moo
pushed a commit
to simon-moo/onnxruntime
that referenced
this pull request
Dec 26, 2022
…osoft#13694) Patch Protobuf and ONNX's cmake files and enforce BinSkim check. This PR has overlap with microsoft#13523 . I would prefer to get this one merged first so that we can finished the BinSkim work, and I try to make this PR as small as possible.
simon-moo
pushed a commit
to simon-moo/onnxruntime
that referenced
this pull request
Dec 26, 2022
… source on MacOS (microsoft#13720) ### Description Add '-DCMAKE_OSX_ARCHITECTURES=x86_64;arm64' when build protobuf from source on MacOS. Because later on we will the built library with the other parts of onnxruntime to generate libonnxruntime.dylib, and if the target CPU ARCH of libonnxruntime.dylib is not x86_64, it will fail. ### Motivation and Context To fix a packaging pipeline failure, which was introduced from microsoft#13694
rui-ren
pushed a commit
that referenced
this pull request
Jan 19, 2023
…CPU_x86_default (#14332) ### Description Allows the PostAnalysis@2 task for windows CI jobs to continue even if an error is encountered. ### Motivation and Context This is a temporary workaround that enables the `Windows_Packaging_CPU_x86_default` job within the Zip-Nuget-Java-NodeJS packaging pipeline to finish. A recent update to dotnet 6 has broken the PostAnalysis task for this job. This task was originally added by #13694
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Patch Protobuf and ONNX's cmake files and enforce BinSkim check.
This PR has overlap with #13523 . I would prefer to get this one merged first so that we can finished the BinSkim work, and I try to make this PR as small as possible.
Motivation and Context