Skip to content

Enable multiple step run for adamw tests (on device training)#14068

Closed
pengwa wants to merge 6 commits intomainfrom
pengwa/adamw_test_fix
Closed

Enable multiple step run for adamw tests (on device training)#14068
pengwa wants to merge 6 commits intomainfrom
pengwa/adamw_test_fix

Conversation

@pengwa
Copy link
Contributor

@pengwa pengwa commented Dec 26, 2022

Enable multiple step run for adamw tests (on device training)

@pengwa pengwa added the training issues related to ONNX Runtime training; typically submitted using template label Dec 26, 2022
askhade
askhade previously approved these changes Jan 31, 2023
Copy link
Contributor

@askhade askhade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

askhade
askhade previously approved these changes Jan 31, 2023
… into pengwa/adamw_test_fix"

This reverts commit 751275d, reversing
changes made to 1887c7c.
@pengwa pengwa requested a review from a team as a code owner February 1, 2023 03:30
@pengwa pengwa requested a review from a team February 1, 2023 03:30
@pengwa pengwa requested a review from a team as a code owner February 1, 2023 03:30
@pengwa
Copy link
Contributor Author

pengwa commented Feb 1, 2023

Sorry I made some mistake during merge main branch, let me revert this PR and re-create one with clean commit.

@pengwa pengwa closed this Feb 1, 2023
pengwa added a commit that referenced this pull request Feb 2, 2023
(cherry picked from commit 414b73a)

### Rework for PR #14068:
Enable multiple step run for adamw tests (on device training)
### Removed duplicated MACRO checks for training.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
@pengwa pengwa deleted the pengwa/adamw_test_fix branch April 11, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

training issues related to ONNX Runtime training; typically submitted using template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants