Skip to content

Conversation

@wschin
Copy link
Contributor

@wschin wschin commented Dec 27, 2022

We should avoid using new and delete in C/C++ code whenever possible as suggested by VC compiler.

@wschin wschin requested a review from yuslepukhin December 27, 2022 23:02
@wschin wschin closed this Jan 3, 2023
@wschin wschin reopened this Jan 3, 2023
@wschin wschin closed this Jan 18, 2023
@wschin wschin reopened this Jan 18, 2023
yuslepukhin
yuslepukhin previously approved these changes Jan 18, 2023
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wschin wschin merged commit 4ef64f3 into main Jan 26, 2023
@wschin wschin deleted the wechi/c26409 branch January 26, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants