Improved test cases by using paramerters#14246
Merged
Conversation
pengwa
reviewed
Jan 12, 2023
| optimizer = Optimizer(optimizer_file_path, model) | ||
|
|
||
| model.train() | ||
| old_params = model.get_contiguous_parameters() |
| # Assert the checkpoint was saved. | ||
| assert os.path.exists(checkpoint_save_path) | ||
|
|
||
| # Assert the checkpoint parameters remains after saving. |
| old_params = model.get_contiguous_parameters() | ||
|
|
||
| # TODO : Load checkpoint to a zeroed model and assert parameters are different. | ||
| # Assert the checkpoint was saved. |
Contributor
There was a problem hiding this comment.
looks this change did complete the TODO "TODO : Load checkpoint to a zeroed model and assert parameters are different."
Contributor
Author
There was a problem hiding this comment.
the change I did will test the same thing, there's no need to create a zeroed model and load it to test if the checkpoint params remain the same.
pengwa
approved these changes
Jan 13, 2023
Contributor
Author
|
Thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completing some missing parts of some test cases for python bindings
Motivation and Context
Some test cases like test_training_module_checkpoint and test_optimizer step were not completed before because we had no access to parameters to check if the parameters are changing after the optimizer step or that the checkpoint saved parameters remains the same.
now that we have access to the vector or parameters by exposing get_contiguous_parameters() method.
we can complete the tests.