Remove exclusions for ONNX model tests that now pass.#14337
Merged
skottmckay merged 3 commits intoJan 23, 2023
Conversation
Update ONNX update doc to point to correct location for tests.
yuslepukhin
previously approved these changes
Jan 18, 2023
| @@ -260,39 +260,28 @@ private static Dictionary<string, string> GetSkippedModels(DirectoryInfo modelsD | |||
| { "test_max_float64", "node test error"}, | |||
| { "test_min_uint8", "node test error"}, | |||
| { "test_mod_mixed_sign_float64", "node test error"}, | |||
edgchen1
reviewed
Jan 18, 2023
…eTest.netcore.cs Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
…usionsForCSharpOnnxModelTestsThatPass
edgchen1
approved these changes
Jan 23, 2023
skottmckay
deleted the
skottmckay/RemoveExclusionsForCSharpOnnxModelTestsThatPass
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove exclusions for ONNX model tests that now pass due to kernels being implemented.
Update ONNX update doc to point to correct location for tests.
Motivation and Context
Run as many tests as possible.