Skip to content

always set OpSchema in CreateNodeHelper()#14356

Merged
fs-eire merged 3 commits intomainfrom
fs-eire/always-set-op-schema-in-create-node-helper
Jan 28, 2023
Merged

always set OpSchema in CreateNodeHelper()#14356
fs-eire merged 3 commits intomainfrom
fs-eire/always-set-op-schema-in-create-node-helper

Conversation

@fs-eire
Copy link
Contributor

@fs-eire fs-eire commented Jan 19, 2023

Description

as a more generic solution to #13660, always set OpSchema in CreateNodeHelper() so that added nodes by transformers will have OpSchema set

Motivation and Context

@fs-eire fs-eire requested a review from skottmckay January 19, 2023 01:42
skottmckay
skottmckay previously approved these changes Jan 26, 2023
Copy link
Contributor

@skottmckay skottmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fs-eire fs-eire merged commit d921968 into main Jan 28, 2023
@fs-eire fs-eire deleted the fs-eire/always-set-op-schema-in-create-node-helper branch January 28, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants