Skip to content

remove mkldnn from gpu nuget package#1443

Merged
jignparm merged 1 commit into
masterfrom
jignparm/fix_gpu_mkldnn
Jul 20, 2019
Merged

remove mkldnn from gpu nuget package#1443
jignparm merged 1 commit into
masterfrom
jignparm/fix_gpu_mkldnn

Conversation

@jignparm
Copy link
Copy Markdown
Contributor

Description: Remove MKLDNN --use_mkldnn from GPU NuGet pipeline

Motivation and Context
This option is not needed in GPU NuGet build.

@jignparm jignparm requested a review from a team as a code owner July 19, 2019 19:21
Copy link
Copy Markdown
Contributor

@pranavsharma pranavsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jignparm jignparm closed this Jul 20, 2019
@snnn snnn deleted the jignparm/fix_gpu_mkldnn branch July 20, 2019 06:03
@jignparm jignparm restored the jignparm/fix_gpu_mkldnn branch July 20, 2019 18:50
@jignparm jignparm reopened this Jul 20, 2019
@jignparm jignparm merged commit 9e4ac8c into master Jul 20, 2019
@jignparm jignparm deleted the jignparm/fix_gpu_mkldnn branch July 20, 2019 18:51
yuslepukhin pushed a commit that referenced this pull request Mar 17, 2026
…eline (#1443)

## Describe your changes
Due to new security restrictions, pipeline secrets are not available in
fork builds.
- Don't run integration tests that require secrets to download data or
submit jobs to aml on fork builds
- Moved example tests that require secret from Olive CI pipeline to
examples or azureml pipelines.
- Remove PR trigger for AML CI pipeline. It runs after merge anyways and
we don't want to worry about permissions for fork builds.

## Checklist before requesting a review
- [ ] Add unit tests for this change.
- [ ] Make sure all tests can pass.
- [ ] Update documents if necessary.
- [ ] Lint and apply fixes to your code by running `lintrunner -a`
- [ ] Is this a user-facing change? If yes, give a description of this
change to be included in the release notes.
- [ ] Is this PR including examples changes? If yes, please remember to
update [example
documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md)
in a follow-up PR.

## (Optional) Issue link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants