Fix Gather to Split optimizer#14478
Merged
Merged
Conversation
xadupre
changed the title
xadupre
changed the title
xadupre
added
api
Lafi7e
reviewed
Feb 1, 2023
|
|
||
| Node& split_node = graph.AddNode(graph.GenerateNodeName("Split"), "Split", "Split for Fused Gather nodes", | ||
| {node.MutableOutputDefs()[0]}, split_outputs); | ||
| {node.MutableOutputDefs()[0]}, indices_n_dims == 0 ? split_outputs: gather_outputs); |
Contributor
There was a problem hiding this comment.
Since we don't need split_outputs when indices_n_dims is not 0, maybe we can put line from 124 to 140 to branch of "if (indices_n_dims == 0)" so that we don't need to create unused NodeArg to the graph by line 139?
Lafi7e
approved these changes
Feb 1, 2023
rui-ren
pushed a commit
that referenced
this pull request
Feb 3, 2023
### Description Gather to Split optimizer fails if opset == 18. This PR fixes one bug and extend unit tests. ### Motivation and Context The model produced by the optimizer does not follow onnx specifications with opset 18.
rui-ren
pushed a commit
that referenced
this pull request
Feb 3, 2023
### Description Gather to Split optimizer fails if opset == 18. This PR fixes one bug and extend unit tests. ### Motivation and Context The model produced by the optimizer does not follow onnx specifications with opset 18.
rui-ren
pushed a commit
that referenced
this pull request
Feb 3, 2023
### Description Gather to Split optimizer fails if opset == 18. This PR fixes one bug and extend unit tests. ### Motivation and Context The model produced by the optimizer does not follow onnx specifications with opset 18.
rui-ren
pushed a commit
that referenced
this pull request
Feb 3, 2023
### Description Gather to Split optimizer fails if opset == 18. This PR fixes one bug and extend unit tests. ### Motivation and Context The model produced by the optimizer does not follow onnx specifications with opset 18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gather to Split optimizer fails if opset == 18. This PR fixes one bug and extend unit tests.
Motivation and Context
The model produced by the optimizer does not follow onnx specifications with opset 18.