Tensor <--> image - Adding per channel compute for Norm mean & Bias#14705
Merged
shalvamist merged 24 commits intomainfrom May 1, 2023
Merged
Tensor <--> image - Adding per channel compute for Norm mean & Bias#14705shalvamist merged 24 commits intomainfrom
shalvamist merged 24 commits intomainfrom
Conversation
Updated the E2E test to cover more configurations of tensor <--> Image utill functions Updated tensor <--> image utill function implemintation - * changed offset to stride (better name) * changed the naming on string use case since it covers both Data URL & URLs on the web
Updated the E2E test for tensor <--> Image conversion Added support for Norm & Bias per channel
Updated the function toDataURL to modify the canvas directly improving performance Updated the name of few variables
fs-eire
reviewed
Feb 17, 2023
fs-eire
reviewed
Feb 17, 2023
fixed a bug in 'toImageData'
…ims_to_norm_n_mean
…ims_to_norm_n_mean
fs-eire
reviewed
Mar 7, 2023
fs-eire
reviewed
Mar 7, 2023
…ims_to_norm_n_mean
fixing documentation
fs-eire
reviewed
Apr 10, 2023
fs-eire
reviewed
Apr 10, 2023
fs-eire
reviewed
Apr 10, 2023
fs-eire
reviewed
Apr 10, 2023
fs-eire
reviewed
Apr 10, 2023
…ims_to_norm_n_mean
Fixed an error in the documentation according the default value of tensorLayout
fs-eire
reviewed
Apr 10, 2023
…ims_to_norm_n_mean
…ims_to_norm_n_mean
…hub.com/microsoft/onnxruntime into Tensor_Image_Adding_dims_to_norm_n_mean
guschmue
previously approved these changes
Apr 27, 2023
guschmue
previously approved these changes
Apr 27, 2023
fs-eire
reviewed
Apr 28, 2023
|
|
||
| if (typeof (norm.mean) === 'number') { | ||
| normMean = [norm.mean, norm.mean, norm.mean, norm.mean]; | ||
| } else { |
Contributor
There was a problem hiding this comment.
if mean could be undefined/null, use another if-else clause to process it. norm.mean![0] may throw error if mean is undefined.
guschmue
approved these changes
May 1, 2023
ShukantPal
pushed a commit
to ShukantPal/onnxruntime
that referenced
this pull request
May 7, 2023
…icrosoft#14705) ### Description Enabled the use of per channel Bias and Mean normalization when converting an image <--> tensor. Added a few bug fixes and updates to the relevant E2E tests. --------- Co-authored-by: shalvamist <shalva.mist@microsoft.com>
siweic0
pushed a commit
to siweic0/onnxruntime-web
that referenced
this pull request
May 9, 2024
…icrosoft#14705) ### Description Enabled the use of per channel Bias and Mean normalization when converting an image <--> tensor. Added a few bug fixes and updates to the relevant E2E tests. --------- Co-authored-by: shalvamist <shalva.mist@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enabled the use of per channel Bias and Mean normalization when converting an image <--> tensor.
Added a few bug fixes and updates to the relevant E2E test