Skip to content

add build flag for rocblas tune and fix bug#14797

Merged
kailums merged 4 commits intomainfrom
add_build_flag_rocblas_tune
Feb 28, 2023
Merged

add build flag for rocblas tune and fix bug#14797
kailums merged 4 commits intomainfrom
add_build_flag_rocblas_tune

Conversation

@kailums
Copy link
Copy Markdown
Contributor

@kailums kailums commented Feb 23, 2023

Description

  1. add a build flag for rocblas tuning feature.

  2. fix a build bug when enable rocblas tuning.

Motivation and Context

The rocblas tunning feature has no build flag to control, only using a MACRO flag.

So I add an build flag, and fix a code bug when enable rocblas tunning.

abudup
abudup previously approved these changes Feb 23, 2023
Copy link
Copy Markdown
Contributor

@abudup abudup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

mindest
mindest previously approved these changes Feb 24, 2023
@kailums kailums dismissed stale reviews from mindest and abudup via 03d34e8 February 27, 2023 05:39
@kailums
Copy link
Copy Markdown
Contributor Author

kailums commented Feb 27, 2023

@abudup @mindest Please review again. I changed rocblas calling arguments from rocblas_gemm_algo_standard to rocblas_gemm_algo_solution_index.

@kailums kailums merged commit 9bdd421 into main Feb 28, 2023
@kailums kailums deleted the add_build_flag_rocblas_tune branch February 28, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants