Linux QNN Pipeline: fix build error reporting#14922
Merged
adrianlizarraga merged 4 commits intomainfrom Mar 7, 2023
Merged
Conversation
HectorSVC
previously approved these changes
Mar 6, 2023
jywu-msft
previously approved these changes
Mar 6, 2023
snnn
reviewed
Mar 6, 2023
snnn
reviewed
Mar 6, 2023
tools/ci_build/github/azure-pipelines/linux-qnn-ci-pipeline.yml
Outdated
Show resolved
Hide resolved
adrianlizarraga
dismissed stale reviews from jywu-msft and HectorSVC
via
6af5191
snnn
approved these changes
Mar 6, 2023
mszhanyi
pushed a commit
that referenced
this pull request
Mar 9, 2023
### Description Split up the ORT build step in the Linux QNN CI Pipeline. ### Motivation and Context Build errors were not being immediately reported at the end of the build step. The build step currently concatenates multiple shell commands, and the return code for the last (mkdir) was being reported. This PR ensures that the return code of the `python build.py ...` command is reported for the build step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split up the ORT build step in the Linux QNN CI Pipeline.
Motivation and Context
Build errors were not being immediately reported at the end of the build step. The build step currently concatenates multiple shell commands, and the return code for the last (mkdir) was being reported. This PR ensures that the return code of the
python build.py ...command is reported for the build step.