Remove the use of eval in test code#15097
Merged
justinchuby merged 9 commits intomicrosoft:mainfrom Mar 20, 2023
Merged
Conversation
WilBrady
previously approved these changes
Mar 17, 2023
Contributor
WilBrady
left a comment
WilBrady
left a comment
There was a problem hiding this comment.
Changes in ort_ops.py look fine to me as long as tests are passing. Thank you.
justinchuby
changed the title
| prediction.backward() | ||
|
|
||
|
|
||
| _ONE = torch.FloatTensor([1]) |
Contributor
There was a problem hiding this comment.
is it possible to make the input local to the test and be passed in as an argument to the lambda?
Contributor
There was a problem hiding this comment.
Please address this in a follow up PR. Thanks.
baijumeswani
approved these changes
Mar 20, 2023
justinchuby
added a commit
that referenced
this pull request
Mar 20, 2023
justinchuby
added a commit
that referenced
this pull request
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the use of
evalin test code so we don't (1) use eval and (2) create "unused" local vars that ruff will remove. Predecessor to #15085