Skip to content

[ROCm] Add compute type for Skiplayernorm to fix ROCm CI#15192

Merged
PeixuanZuo merged 2 commits intomainfrom
peixuanzuo/fix_skiplayernorm
Mar 24, 2023
Merged

[ROCm] Add compute type for Skiplayernorm to fix ROCm CI#15192
PeixuanZuo merged 2 commits intomainfrom
peixuanzuo/fix_skiplayernorm

Conversation

@PeixuanZuo
Copy link
Contributor

@PeixuanZuo PeixuanZuo commented Mar 24, 2023

  • Add compute type for Skiplayernorm to fix ROCm CI and get more accurate results.

SkipLayerNorm:
type T: input, skip, bias
type U: epsilon, compute result
type V: output, beta, gamma

  • refactor the usage of aligned_vector, reduce the usage of reinterpret_cast.

@PeixuanZuo PeixuanZuo requested review from cloudhan and mindest March 24, 2023 05:26
@PeixuanZuo PeixuanZuo force-pushed the peixuanzuo/fix_skiplayernorm branch from 2de2f48 to ff53fcb Compare March 24, 2023 05:37
@PeixuanZuo PeixuanZuo force-pushed the peixuanzuo/fix_skiplayernorm branch from ff53fcb to 5461928 Compare March 24, 2023 07:36
@PeixuanZuo PeixuanZuo merged commit 7eb6dbe into main Mar 24, 2023
@PeixuanZuo PeixuanZuo deleted the peixuanzuo/fix_skiplayernorm branch March 24, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants