Skip to content

[CoreML EP] Add support for LeakyReLU activation layers#15327

Merged
YUNQIUGUO merged 3 commits intomicrosoft:mainfrom
ShukantPal:main
Apr 10, 2023
Merged

[CoreML EP] Add support for LeakyReLU activation layers#15327
YUNQIUGUO merged 3 commits intomicrosoft:mainfrom
ShukantPal:main

Conversation

@ShukantPal
Copy link
Contributor

Description

Implements support for LeakyReLU in ActivationOpBuilder for CoreML's EP.

Motivation and Context

This speeds up inference on macOS significantly for models using LeakyReLU.

## Description

Implements support for LeakyReLU in ActivationOpBuilder for CoreML's EP. This speeds up inference on macOS significantly for models using LeakyReLU.
@ShukantPal
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Contributor

@YUNQIUGUO YUNQIUGUO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

@ShukantPal
Copy link
Contributor Author

Thanks for the review @YUNQIUGUO! − I implemented your suggestion.

@YUNQIUGUO
Copy link
Contributor

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-python-checks-ci-pipeline, ONNX Runtime React Native CI Pipeline 

@azure-pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@YUNQIUGUO
Copy link
Contributor

/azp run CoreML CI Pipeline, iOS CI Pipeline, Android CI Pipeline, ONNX Runtime Web CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@YUNQIUGUO
Copy link
Contributor

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

@YUNQIUGUO
Copy link
Contributor

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-python-checks-ci-pipeline, ONNX Runtime React Native CI Pipeline 

@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@natke
Copy link
Contributor

natke commented Apr 5, 2023

If you can, please share the models/scenarios you are using with this op. Thanks!

@edgchen1
Copy link
Contributor

edgchen1 commented Apr 7, 2023

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

@edgchen1
Copy link
Contributor

edgchen1 commented Apr 7, 2023

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-python-checks-ci-pipeline, ONNX Runtime React Native CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@edgchen1
Copy link
Contributor

edgchen1 commented Apr 7, 2023

/azp run Windows ARM64 QNN CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ShukantPal ShukantPal requested a review from YUNQIUGUO April 10, 2023 19:42
@YUNQIUGUO YUNQIUGUO merged commit 6657df9 into microsoft:main Apr 10, 2023
skottmckay pushed a commit that referenced this pull request May 24, 2023
### Description

This change is a follow-up to #15327. It adds Unary operators (Sqrt,
Reciprocal) and Reduce operators (ReduceSum, ReduceMean). I've tried to
follow existing patterns in the code :-)


### Motivation and Context

This reduces fragmentation across EPs when using CoreML on macOS,
thereby speeding up execution.

---------

Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants