For HLSL shader ops in the DirectML EP (STFT,DFT) FP16 ops should fallback to CPU when there is no hardware support#15414
Merged
smk2007 merged 3 commits intoApr 10, 2023
Conversation
…hardware doesnt support FP16 and the op is constructed with FP16
smk2007
requested review from
PatriceVignola,
jstoecker,
martinb35 and
sumitsays
jstoecker
suggested changes
Apr 6, 2023
jstoecker
reviewed
Apr 6, 2023
jstoecker
approved these changes
Apr 6, 2023
PatriceVignola
approved these changes
Apr 7, 2023
smk2007
added a commit
that referenced
this pull request
Apr 10, 2023
…lback to CPU when there is no hardware support (#15414) For HLSL shader ops in the DirectML EP (STFT,DFT) FP16 ops should fallback to CPU when there is no hardware support
preetha-intel
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Jun 6, 2023
…lback to CPU when there is no hardware support (microsoft#15414) For HLSL shader ops in the DirectML EP (STFT,DFT) FP16 ops should fallback to CPU when there is no hardware support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For HLSL shader ops in the DirectML EP (STFT,DFT) FP16 ops should fallback to CPU when there is no hardware support