Fix FusedConv for ROCm#15460
Merged
Merged
Conversation
Contributor
cloudhan
commented
Apr 11, 2023
cloudhan
commented
- Fix undesired runtime optimization for non-Relu activation.
- Refactor
- Fix false positive runtime error due to fusion failure.
cloudhan
requested review from
PeixuanZuo,
RandySheriffH,
abudup,
kailums and
zhangyaobit
cloudhan
force-pushed
the
guangyunhan/fused-conv
branch
from
5d27603 to
b7c5b34
Compare
kailums
reviewed
Apr 12, 2023
PeixuanZuo
reviewed
Apr 12, 2023
Contributor
|
LGTM |
abudup
suggested changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.