[js/rn] Package dependency change to manage ort-extensions for react_native app

[YUNQIUGUO]

Description

js/react_native package dependency change to manage ort-extensions for react-native app.

Enable optional inclusion of ort-ext aar/ ort-ext pods for react-native extensions apps when specifiy ortExtensionsEnabled in user's package.json file

Motivation and Context

[edgchen1]

so this include doesn't require any leading directory?

[YUNQIUGUO]

correct, this one works fine. it's the <onnxruntime_c_api.h> this extensions header includes requires a leading directory.

[YUNQIUGUO]

update: actually looks like just getting rid of https://github.com/microsoft/onnxruntime-extensions/blob/0e2d6c03e4b87f49e6d35c1ca540e99317ac8bb9/includes/onnxruntime_extensions.h#L5
this line here would work with the project. (i.e. no "redefinition" error at compile stage for objects defined in onnxruntime_c_api.h)

I guess this c_api include in extensions header isn't really necessary.

[skottmckay]

Does this require a change on the ort extensions side for it to work? If so are there any objections to that change?

[edgchen1]

@wenbingl what do you think? could we remove the onnxruntime_c_api.h include from here and just forward declare the ORT types?

[YUNQIUGUO]

Does this require a change on the ort extensions side for it to work? If so are there any objections to that change?

yeah... hopefully we can just remove that line as Ed pined above.

[wenbingl]

@wenbingl what do you think? could we remove the onnxruntime_c_api.h include from here and just forward declare the ORT types?

onnxruntime_extensions.h is the only ABI head file for ort-extensions, and Register... function depends on some types defined c_api.h. Can we assume that every time the onnxruntime_extensions.h is included, onnxruntme_c_api.h already included before that?

I don't know what the issue is here? redefinition? Suppose there will be only one copy of onnxruntime_c_api.h in the whole build since ort-extensions can use onnxruntime_c_api.h from internal folder, if not, that's something should be fixed.

[YUNQIUGUO]

I don't know what the issue is here? redefinition? Suppose there will be only one copy of onnxruntime_c_api.h in the whole build since ort-extensions can use onnxruntime_c_api.h from internal folder, if not, that's something should be fixed.

yea, I experienced a redefinition error when building a react native app on the ios side. I guess it duplicates with the onnxruntime_c_api.h header that already been included from the onnxruntime-c pod.

I will try to seek ways to not making changes on the ort-extensions side first.

[wenbingl]

The ort header file are setting here: https://github.com/microsoft/onnxruntime-
extensions/blob/f12270b06858b2a57c6fa5041c39d835a707060f/cmake/ext_ortlib.cmake#L2
You may make some change here if needed to make sure the right header file can be found.

[YUNQIUGUO]

not specifying public here for this class as other wise compiler would complain about the class name not match the file name. but in our case, it should be fine as if not specified, will by default be package-specific. We only will call and use this class within the same package bundle ai.onnxruntime.reactnative

[skottmckay]

nit: Can we update the message to tell them how to enable it as clearly they're wanting to?

[edgchen1]

nit: add space

Suggested change

	"ORT Extensions is not enabled in the current configuration. If you want to enable this support,"
	"ORT Extensions is not enabled in the current configuration. If you want to enable this support, "

[edgchen1]

also the first argument is a tag, maybe it should be something like "OnnxruntimeExtensions". if you want an info log instead of debug, use Log.i()

[YUNQIUGUO]

right got it. thanks!