Skip to content

Fix release version suffix for RC builds (#15865)#15901

Merged
snnn merged 4 commits intorel-1.15.0from
natke/fix-rc-version-cherrypick
May 11, 2023
Merged

Fix release version suffix for RC builds (#15865)#15901
snnn merged 4 commits intorel-1.15.0from
natke/fix-rc-version-cherrypick

Conversation

@natke
Copy link
Contributor

@natke natke commented May 10, 2023

Cherry pick nuget RC version changes from main

(cherry picked from commit 36c9ae0)

@natke natke requested a review from a team May 10, 2023 22:19
@snnn snnn requested a review from pranavsharma May 10, 2023 22:33
@snnn
Copy link
Contributor

snnn commented May 10, 2023

Does this one depend on PR #15839 ? Does that one also need be cherry-picked?

@natke
Copy link
Contributor Author

natke commented May 10, 2023

Does this one depend on PR #15839 ? Does that one also need be cherry-picked?

That is a good question. I think this PR will standalone, as the ReleaseVersionSuffix should have been set everywhere that it is used but let me check.

@natke
Copy link
Contributor Author

natke commented May 10, 2023

I have manually added in the default (rather than cherry pick the other PR). I don't think we need this default because the variable should be explicitly set everywhere it is used, but I am adding it to be safe in all cases.

snnn
snnn approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@natke
Copy link
Contributor Author

natke commented May 11, 2023

This needs one more review right? And there is an android pipeline failing due to a cmake version mismatch

@snnn
Copy link
Contributor

snnn commented May 11, 2023

And there is an android pipeline failing due to a cmake version mismatch

Yes. It will be fixed by another cherry-pick from me. Now you can ignore it.

@snnn snnn merged commit ed46afd into rel-1.15.0 May 11, 2023
@snnn snnn deleted the natke/fix-rc-version-cherrypick branch May 11, 2023 16:19
preetha-intel pushed a commit to intel/onnxruntime that referenced this pull request Jun 7, 2023
@natke @preetha-intel
Fix release version suffix for RC builds (microsoft#15865) (microsoft…
ea3b5a5 
…#15901)

Cherry pick nuget RC version changes from main

(cherry picked from commit 36c9ae0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@snnn snnn snnn approved these changes

@pranavsharma pranavsharma pranavsharma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@natke @snnn @pranavsharma