Skip to content

Update url and checksum in Package.swift with the 1.15.0 iOS package details#16174

Merged
skottmckay merged 1 commit intorel-1.15.0from
skottmckay/UpdateSwiftPackageManagerWithReleaseBinary
Jun 6, 2023
Merged

Update url and checksum in Package.swift with the 1.15.0 iOS package details#16174
skottmckay merged 1 commit intorel-1.15.0from
skottmckay/UpdateSwiftPackageManagerWithReleaseBinary

Conversation

@skottmckay
Copy link
Contributor

Description

Update Package.swift on the release branch with the url and checksum from the release iOS pod.

Motivation and Context

Swift Package Manager refers to the file in the repo directly, and we couldn't update the checksum until the release was done.

@skottmckay skottmckay requested a review from edgchen1 May 31, 2023 06:27
@edgchen1 edgchen1 requested review from pranavsharma and snnn May 31, 2023 16:15
Copy link
Contributor

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this step.

@edgchen1
Copy link
Contributor

Sorry I missed this step.

It's not your fault, this is a new step.

@pranavsharma
Copy link
Contributor

Usually, we don't check-in code directly in the release branch. It's rather cherry picked from main for consistency. I'll leave it to @snnn to ensure that it's backported to main.
All 1.15 release pkgs should have the exact same commit id. If a pkg is released using this fix, the commit id will differ.

@snnn
Copy link
Contributor

snnn commented May 31, 2023

It seems this one should not be in the main branch?

@edgchen1
Copy link
Contributor

It seems this one should not be in the main branch?

That's right - it should not be in main because it points to a 1.15 release artifact.

@skottmckay skottmckay merged commit 0a381cc into rel-1.15.0 Jun 6, 2023
@skottmckay skottmckay deleted the skottmckay/UpdateSwiftPackageManagerWithReleaseBinary branch June 6, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants