Cfu revertamx#16455
Merged
Merged
Conversation
yufenglee
approved these changes
Jun 23, 2023
jchen351
reviewed
Jun 23, 2023
|
|
||
| set(MLAS_AMX_SUPPORTED FALSE) | ||
|
|
||
| if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL 11) |
Contributor
There was a problem hiding this comment.
Can we make this to 11.2 instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is to revert two PRs that aim at reducing AMX toolchain requirements. Unfortunately we still have some pipeline issues.
#16390
#16086
Motivation and Context
Looks like gcc link time optimization does not work very well with inline assembly in the above PRs.