Skip to content

[ROCm] fix shell bug#16641

Merged
PeixuanZuo merged 1 commit intomainfrom
peixuanzuo/fix_shell_bug
Jul 10, 2023
Merged

[ROCm] fix shell bug#16641
PeixuanZuo merged 1 commit intomainfrom
peixuanzuo/fix_shell_bug

Conversation

@PeixuanZuo
Copy link
Copy Markdown
Contributor

@PeixuanZuo PeixuanZuo commented Jul 10, 2023 •
edited
Loading

set -ex with grep will exit when grep doesn't meet any string.

@PeixuanZuo PeixuanZuo requested a review from mindest July 10, 2023 06:49
@PeixuanZuo PeixuanZuo merged commit 2fd5e1c into main Jul 10, 2023
@PeixuanZuo PeixuanZuo deleted the peixuanzuo/fix_shell_bug branch July 10, 2023 09:31
mszhanyi added a commit that referenced this pull request Jul 11, 2023
@mszhanyi
Revert "[ROCm] fix shell bug (#16641)"
3a86d5a 
This reverts commit 2fd5e1c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mindest mindest mindest approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PeixuanZuo @mindest