implement DynamicQuantizeMatMul#16757
Merged
zhangxiang1993 merged 5 commits intoDmlPrototypefrom Jul 21, 2023
Merged
Conversation
| operatorGraphDesc.nodesAsOpDesc = opDescs.data(); | ||
|
|
||
| // set input edges | ||
| std::pair<uint32_t, uint32_t> nodeToNodeInputIndex[5] {{0, 0}, {1, 3}, {1, 4}, {1, 5}, {1, 6}}; |
Contributor
There was a problem hiding this comment.
Since you're using OnnxInputIndex::Count below, we should be probably do it here as well instead of hardcoding a 5
Comment on lines
+111
to
+112
| operatorGraphDesc.nodeCount = 2; | ||
| std::vector<const DML_OPERATOR_DESC*> opDescs{&opDesc1, &opDesc2}; |
Contributor
There was a problem hiding this comment.
I suggest inverting those 2 lines and use opDescs.size() for the nodeCount instead.
Contributor
|
LGTM, just a few nits. Do you need to enable tests are are they already enabled? |
Contributor
Author
|
Yeah, the tests were already enabled, I did nothing for the tests, the PR tile is confusing In reply to: 1642765909 |
PatriceVignola
approved these changes
Jul 21, 2023
fdwr
reviewed
Jul 25, 2023
| constexpr static std::array<SupportedTensorDataTypes, 2> supportedTypeListDynamicQuantizeLinear = { | ||
| SupportedTensorDataTypes::Float32, | ||
| SupportedTensorDataTypes::UInt8, | ||
| SupportedTensorDataTypes::Int8|SupportedTensorDataTypes::UInt8 |
Contributor
There was a problem hiding this comment.
I notice your other change used SupportedTensorDataTypes::Ints8Bit. Consider using that here too in the future.
AnaghaRaoAMD
pushed a commit
that referenced
this pull request
Nov 2, 2023
This PR implement [com.microsoft.DynamicQuantizeMatMul](https://github.com/microsoft/onnxruntime/blob/main/docs/ContribOperators.md#commicrosoftdynamicquantizematmul) 
AnaghaRaoAMD
pushed a commit
that referenced
this pull request
Nov 6, 2023
This PR implement [com.microsoft.DynamicQuantizeMatMul](https://github.com/microsoft/onnxruntime/blob/main/docs/ContribOperators.md#commicrosoftdynamicquantizematmul) 
AnaghaRaoAMD
added a commit
that referenced
this pull request
Nov 6, 2023
[Cherry Pick Reviewed] This PR implement [com.microsoft.DynamicQuantizeMatMul](https://github.com/microsoft/onnxruntime/blob/main/docs/ContribOperators.md#commicrosoftdynamicquantizematmul)  ### Description <!-- Describe your changes. --> ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Co-authored-by: Xiang Zhang <xianz@microsoft.com>
AnaghaRaoAMD
added a commit
that referenced
this pull request
Mar 4, 2024
[Cherry Pick Reviewed] This PR implement [com.microsoft.DynamicQuantizeMatMul](https://github.com/microsoft/onnxruntime/blob/main/docs/ContribOperators.md#commicrosoftdynamicquantizematmul)  <!-- Describe your changes. --> <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Co-authored-by: Xiang Zhang <xianz@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implement com.microsoft.DynamicQuantizeMatMul