Skip to content

Allow --build_wasm on a mac system#16761

Merged
fs-eire merged 2 commits intomicrosoft:mainfrom
dakenf:wasm-mac-build
Jul 21, 2023
Merged

Allow --build_wasm on a mac system#16761
fs-eire merged 2 commits intomicrosoft:mainfrom
dakenf:wasm-mac-build

Conversation

@dakenf
Copy link
Copy Markdown
Contributor

@dakenf dakenf commented Jul 19, 2023

Description

Changes allow downloading prebuilt protoc compiler when building WebAssebly version on mac systems.
Otherwise it tries to build a js/wasm version of protoc and throws an error while executing it: "protoc.js permission denied"

Motivation and Context

I need to switch between my main working computer and a PC to make changes to WebAssebly build. Would like not to do that anymore.

@guschmue guschmue requested a review from fs-eire July 20, 2023 15:00
@fs-eire
Copy link
Copy Markdown
Contributor

fs-eire commented Jul 20, 2023

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

@fs-eire
Copy link
Copy Markdown
Contributor

fs-eire commented Jul 20, 2023

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows ARM64 QNN CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, ONNX Runtime React Native CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

No commit pushedDate could be found for PR 16761 in repo microsoft/onnxruntime

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 9 pipeline(s).

@fs-eire
Copy link
Copy Markdown
Contributor

fs-eire commented Jul 20, 2023

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows ARM64 QNN CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, ONNX Runtime React Native CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

No commit pushedDate could be found for PR 16761 in repo microsoft/onnxruntime

@fs-eire
Copy link
Copy Markdown
Contributor

fs-eire commented Jul 21, 2023

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows ARM64 QNN CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, ONNX Runtime React Native CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 8 pipeline(s).

@fs-eire fs-eire merged commit 210d29b into microsoft:main Jul 21, 2023
snnn pushed a commit that referenced this pull request Jul 31, 2023
… source (#16906)

### Description
1. As a follow-up of #16761, this PR allows build ORT on iOS/Android
without the need to explicitly specify a protoc path. #16761 is for
WASM. This one is for iOS/Android
2. Update the MacOS/Linux build scripts that build/install protobuf from
source. Make them be more flexible. Add the support for
RedHatEnterprise(ubi), which will needed for upgrading the base image
from centos:7 to ubi:8.
3. Update tools/ci_build/github/pai/rocm-ci-pipeline-env.Dockerfile :
the docker file's base image has preinstalled protobuf in /usr/local, we
should uninstall them to avoid conflicts.
jchen351 pushed a commit that referenced this pull request Aug 12, 2023
### Description
Changes allow downloading prebuilt protoc compiler when building
WebAssebly version on mac systems.
Otherwise it tries to build a js/wasm version of protoc and throws an
error while executing it: "protoc.js permission denied"


### Motivation and Context
I need to switch between my main working computer and a PC to make
changes to WebAssebly build. Would like not to do that anymore.
jchen351 pushed a commit that referenced this pull request Aug 12, 2023
… source (#16906)

### Description
1. As a follow-up of #16761, this PR allows build ORT on iOS/Android
without the need to explicitly specify a protoc path. #16761 is for
WASM. This one is for iOS/Android
2. Update the MacOS/Linux build scripts that build/install protobuf from
source. Make them be more flexible. Add the support for
RedHatEnterprise(ubi), which will needed for upgrading the base image
from centos:7 to ubi:8.
3. Update tools/ci_build/github/pai/rocm-ci-pipeline-env.Dockerfile :
the docker file's base image has preinstalled protobuf in /usr/local, we
should uninstall them to avoid conflicts.
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
… source (microsoft#16906)

### Description
1. As a follow-up of microsoft#16761, this PR allows build ORT on iOS/Android
without the need to explicitly specify a protoc path. microsoft#16761 is for
WASM. This one is for iOS/Android
2. Update the MacOS/Linux build scripts that build/install protobuf from
source. Make them be more flexible. Add the support for
RedHatEnterprise(ubi), which will needed for upgrading the base image
from centos:7 to ubi:8.
3. Update tools/ci_build/github/pai/rocm-ci-pipeline-env.Dockerfile :
the docker file's base image has preinstalled protobuf in /usr/local, we
should uninstall them to avoid conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants