[java] Fp16 fix for android/react native by Craigacp · Pull Request #16832 · microsoft/onnxruntime

Craigacp · 2023-07-24T15:56:49Z

Description

This PR splits out the FP16 conversions into a separate package we can override in the android build with a version which works on old versions of Android.

I'm not sure the android build system changes are correct as I haven't got an android build environment configured on my workstation. @YUNQIUGUO if the CI build fails we should follow up offline to get my environment configured so I can iterate on it.

Motivation and Context

Fixes the CI failure after #16703.

yuslepukhin · 2023-07-24T17:53:18Z

/azp run MacOS CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-python-checks-ci-pipeline

azure-pipelines · 2023-07-24T17:53:44Z

Azure Pipelines successfully started running 5 pipeline(s).

yuslepukhin · 2023-07-24T17:54:06Z

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, Windows ARM64 QNN CI Pipeline

azure-pipelines · 2023-07-24T17:54:34Z

Azure Pipelines successfully started running 7 pipeline(s).

yuslepukhin · 2023-07-24T17:55:55Z

/azp run orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-binary-size-checks-ci-pipeline

azure-pipelines · 2023-07-24T17:56:00Z

No commit pushedDate could be found for PR 16832 in repo microsoft/onnxruntime

yuslepukhin · 2023-07-24T17:57:39Z

/azp run orttraining-linux-ci-pipeline

azure-pipelines · 2023-07-24T17:57:48Z

Azure Pipelines successfully started running 1 pipeline(s).

yuslepukhin · 2023-07-24T17:58:11Z

/azp run orttraining-linux-gpu-ci-pipeline

azure-pipelines · 2023-07-24T17:58:19Z

Azure Pipelines successfully started running 1 pipeline(s).

yuslepukhin · 2023-07-24T17:58:39Z

/azp run orttraining-ortmodule-distributed

azure-pipelines · 2023-07-24T17:58:48Z

Azure Pipelines successfully started running 1 pipeline(s).

yuslepukhin · 2023-07-24T17:59:13Z

/azp run onnxruntime-binary-size-checks-ci-pipeline

azure-pipelines · 2023-07-24T17:59:22Z

Azure Pipelines successfully started running 1 pipeline(s).

YUNQIUGUO · 2023-07-24T18:11:12Z

/azp run ONNX Runtime React Native CI Pipeline

azure-pipelines · 2023-07-24T18:11:21Z

Azure Pipelines successfully started running 1 pipeline(s).

Craigacp · 2023-07-24T18:58:11Z

One day I'll remember to run spotless after making small changes before making the commit, but it wasn't today apparently. I've pushed the spotless fixes so those test failures out of the Java side should go away and we'll hit the actual code changes.

Craigacp · 2023-07-24T19:00:58Z

Looks like Android wasn't happy about the packaging changes either, so I'll need to iterate on that (https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1074203&view=logs&j=06bda0f0-c359-5ee8-d76d-283c2733373e&t=af31bba3-008c-59d3-c2d1-f81f08a354ff&l=6566).

yuslepukhin · 2023-07-24T19:04:42Z

/azp run MacOS CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-python-checks-ci-pipeline

yuslepukhin · 2023-07-24T19:04:51Z

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, Windows ARM64 QNN CI Pipeline

azure-pipelines · 2023-07-24T19:04:56Z

No commit pushedDate could be found for PR 16832 in repo microsoft/onnxruntime

azure-pipelines · 2023-07-24T19:05:06Z

Azure Pipelines successfully started running 5 pipeline(s).

yuslepukhin · 2023-07-24T19:05:08Z

/azp run ONNX Runtime React Native CI Pipeline

yuslepukhin · 2023-07-24T19:05:19Z

/azp run orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-binary-size-checks-ci-pipeline

azure-pipelines · 2023-07-24T19:05:19Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2023-07-24T19:05:39Z

Azure Pipelines successfully started running 4 pipeline(s).

yuslepukhin · 2023-07-24T19:06:02Z

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, Windows ARM64 QNN CI Pipeline

azure-pipelines · 2023-07-24T19:06:33Z

Azure Pipelines successfully started running 7 pipeline(s).

yuslepukhin · 2023-07-24T19:07:22Z

/azp run Windows_SCA

azure-pipelines · 2023-07-24T19:07:27Z

No pipelines are associated with this pull request.

yuslepukhin · 2023-07-24T19:07:52Z

/azp run Windows_SCA/Onnxruntime-SCA-training-CUDA

azure-pipelines · 2023-07-24T19:07:57Z

No pipelines are associated with this pull request.

yuslepukhin · 2023-07-24T19:38:18Z

/azp run MacOS CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-python-checks-ci-pipeline

azure-pipelines · 2023-07-24T19:38:40Z

Azure Pipelines successfully started running 5 pipeline(s).

YUNQIUGUO · 2023-07-24T20:18:30Z

/azp run ONNX Runtime React Native CI Pipeline

azure-pipelines · 2023-07-24T20:18:40Z

Azure Pipelines successfully started running 1 pipeline(s).

Craigacp · 2023-07-25T00:43:54Z

After further consideration I split the Java code into three source roots. The shared code is in src/main/java, the Android specific stuff (which at the moment is just the FP16 conversions) is in src/main/android and the Java/JVM specific stuff is in src/main/jvm. I've tested the Java build and that works, and the Android build seems to be failing at a different point further on than the React pipeline error that we saw which I think is due to the misconfigured Android build environment I've cobbled together to test it. I'm hopeful that this will work, but it's probably worth running just the react native pipeline and one of the other ones with Java turned on first to make it easier for me to see the failures (which hopefully there won't be).

YUNQIUGUO · 2023-07-25T07:23:52Z

/azp run ONNX Runtime React Native CI Pipeline

azure-pipelines · 2023-07-25T07:24:04Z

Azure Pipelines successfully started running 1 pipeline(s).

mszhanyi · 2023-07-25T08:29:19Z

/azp run Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline

azure-pipelines · 2023-07-25T08:29:58Z

Azure Pipelines successfully started running 10 pipeline(s).

mszhanyi · 2023-07-25T08:31:22Z

/azp run Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-python-checks-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline

azure-pipelines · 2023-07-25T08:31:48Z

Azure Pipelines successfully started running 7 pipeline(s).

YUNQIUGUO

thanks for the fix!

@YUNQIUGUO

### Description This PR splits out the FP16 conversions into a separate package we can override in the android build with a version which works on old versions of Android. I'm not sure the android build system changes are correct as I haven't got an android build environment configured on my workstation. @YUNQIUGUO if the CI build fails we should follow up offline to get my environment configured so I can iterate on it. ### Motivation and Context Fixes the CI failure after #16703.

Craigacp added 2 commits July 24, 2023 11:51

Splitting out the android version of the fp16 conversion.

acbb0ab

Updating the package docs.

367660f

Craigacp mentioned this pull request Jul 24, 2023

[java] Adds support for fp16 and bf16 tensors #16703

Merged

Spotless fixes.

0ecf8a2

Trying to fix the package exclusion syntax.

1d4cba5

Split the Java code into two source roots.

55c3187

microsoft deleted a comment from azure-pipelines bot Jul 25, 2023

skottmckay approved these changes Jul 25, 2023

View reviewed changes

YUNQIUGUO approved these changes Jul 25, 2023

View reviewed changes

YUNQIUGUO merged commit a1bb670 into microsoft:main Jul 25, 2023

Conversation

Craigacp commented Jul 24, 2023

Description

Motivation and Context

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

YUNQIUGUO commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

Craigacp commented Jul 24, 2023

Uh oh!

Craigacp commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

yuslepukhin commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

YUNQIUGUO commented Jul 24, 2023

Uh oh!

azure-pipelines bot commented Jul 24, 2023

Uh oh!

Craigacp commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Craigacp commented Jul 25, 2023 •

edited

Loading