[js/webgpu] Support int32 type for binary by xhcao · Pull Request #16901 · microsoft/onnxruntime

xhcao · 2023-07-28T07:56:43Z

Description

Enable typed binary and support int32 type for binary.

Co-authored-by: Xing Xu xing.xu@intel.com

xhcao · 2023-07-28T08:19:06Z

@qjia7 @gyagp, PTAL

qjia7

Overall looks good. Just some nits.
Will transfer it to @fs-eire @guschmue to review. Thanks.

onnxruntime/core/providers/js/operators/binary.cc

js/web/lib/wasm/jsep/webgpu/ops/binary-op.ts

guschmue · 2023-07-28T15:59:40Z

/azp run ONNX Runtime Web CI Pipeline

azure-pipelines · 2023-07-28T15:59:45Z

No commit pushedDate could be found for PR 16901 in repo microsoft/onnxruntime

guschmue · 2023-07-31T19:57:53Z

CI pipeline is nagging:

You can reproduce these results locally by using `lintrunner`. To set up lintrunner locally, see https://github.com/microsoft/onnxruntime/blob/main/docs/Coding_Conventions_and_Standards.md#linting .
Error: Process completed with exit code 1.

js/web/lib/wasm/wasm-common.ts

onnxruntime/core/providers/js/js_execution_provider.cc

axinging

@fs-eire, your comments are resolved, PTAL

onnxruntime/core/providers/js/js_execution_provider.cc

js/web/lib/wasm/wasm-common.ts

guschmue · 2023-08-01T16:37:38Z

/azp run ONNX Runtime Web CI Pipeline

azure-pipelines · 2023-08-01T16:37:48Z

Azure Pipelines successfully started running 1 pipeline(s).

guschmue · 2023-08-01T20:19:37Z

lint nagging:
C:\a_work\1\s\js\web\lib\wasm\jsep\webgpu\ops\binary-op.ts
185:7 error Assignment to function parameter 'cacheKey' no-param-reassign
185:27 error Expected '===' and instead saw '==' eqeqeq

You can run it local from the js/ directory with
npm run lint

axinging · 2023-08-02T00:38:10Z

lint nagging: C:\a_work\1\s\js\web\lib\wasm\jsep\webgpu\ops\binary-op.ts 185:7 error Assignment to function parameter 'cacheKey' no-param-reassign 185:27 error Expected '===' and instead saw '==' eqeqeq

You can run it local from the js/ directory with npm run lint

Thanks @guschmue, lint is done, PTAL

fs-eire · 2023-08-02T04:03:35Z

/azp run ONNX Runtime Web CI Pipeline

azure-pipelines · 2023-08-02T04:03:45Z

Azure Pipelines successfully started running 1 pipeline(s).

guschmue · 2023-08-02T15:38:03Z

/azp run ONNX Runtime Web CI Pipeline

azure-pipelines · 2023-08-02T15:38:14Z

Azure Pipelines successfully started running 1 pipeline(s).

guschmue · 2023-08-02T21:48:02Z

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

azure-pipelines · 2023-08-02T21:48:27Z

Azure Pipelines successfully started running 6 pipeline(s).

guschmue · 2023-08-02T21:48:57Z

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

azure-pipelines · 2023-08-02T21:49:03Z

No commit pushedDate could be found for PR 16901 in repo microsoft/onnxruntime

guschmue · 2023-08-15T01:07:04Z

/azp run ONNX Runtime Web CI Pipeline

azure-pipelines · 2023-08-15T01:07:14Z

Azure Pipelines successfully started running 1 pipeline(s).

guschmue · 2023-08-15T18:03:17Z

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

azure-pipelines · 2023-08-15T18:43:58Z

Azure Pipelines successfully started running 1 pipeline(s).

guschmue · 2023-08-15T19:06:37Z

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

azure-pipelines · 2023-08-15T19:38:24Z

Azure Pipelines successfully started running 2 pipeline(s).

js/web/lib/wasm/jsep/webgpu/ops/binary-op.ts

fs-eire · 2023-08-16T04:15:29Z

/azp run ONNX Runtime Web CI Pipeline

azure-pipelines · 2023-08-16T04:15:40Z

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: Xing Xu <xing.xu@intel.com>

lintrunner passed in local, but bots failed duw to: onnxruntime/core/providers/js/operators/binary.cc:9: Lines should be <= 120 characters long [whitespace/line_length] [2]

fs-eire · 2023-08-17T04:18:13Z

/azp run ONNX Runtime Web CI Pipeline

azure-pipelines · 2023-08-17T04:18:24Z

Azure Pipelines successfully started running 1 pipeline(s).

guschmue · 2023-08-17T16:55:43Z

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

azure-pipelines · 2023-08-17T16:55:56Z

Azure Pipelines successfully started running 1 pipeline(s).

guschmue · 2023-08-17T16:56:10Z

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

azure-pipelines · 2023-08-17T16:56:25Z

Azure Pipelines successfully started running 2 pipeline(s).

### Description Enable typed binary and support int32 type for binary. Co-authored-by: Xing Xu <xing.xu@intel.com> --------- Co-authored-by: Xing Xu <xing.xu@intel.com>

xhcao force-pushed the webgpu_typedbinary branch from 11f995a to 45a0db2 Compare July 28, 2023 08:17

xhcao marked this pull request as ready for review July 28, 2023 08:18

xhcao changed the title ~~[js/web] Support int32 type for binary~~ [js/webgpu] Support int32 type for binary Jul 28, 2023

qjia7 reviewed Jul 28, 2023

View reviewed changes

onnxruntime/core/providers/js/operators/binary.cc Show resolved Hide resolved

js/web/lib/wasm/jsep/webgpu/ops/binary-op.ts Outdated Show resolved Hide resolved

xhcao force-pushed the webgpu_typedbinary branch from 45a0db2 to 7812f53 Compare July 28, 2023 09:24

xhcao force-pushed the webgpu_typedbinary branch from 7812f53 to 4c8c92e Compare July 31, 2023 01:42

guschmue added the ep:WebGPU ort-web webgpu provider label Jul 31, 2023

fs-eire reviewed Jul 31, 2023

View reviewed changes

js/web/lib/wasm/wasm-common.ts Outdated Show resolved Hide resolved

fs-eire reviewed Jul 31, 2023

View reviewed changes

onnxruntime/core/providers/js/js_execution_provider.cc Show resolved Hide resolved

xhcao force-pushed the webgpu_typedbinary branch from 4c8c92e to 4da97a9 Compare August 1, 2023 03:28

axinging reviewed Aug 1, 2023

View reviewed changes

onnxruntime/core/providers/js/js_execution_provider.cc Show resolved Hide resolved

js/web/lib/wasm/wasm-common.ts Outdated Show resolved Hide resolved

xhcao force-pushed the webgpu_typedbinary branch from 4da97a9 to 55b3d87 Compare August 1, 2023 05:08

xhcao force-pushed the webgpu_typedbinary branch from 55b3d87 to d92caff Compare August 2, 2023 00:36

xhcao force-pushed the webgpu_typedbinary branch from d92caff to 5f7eea5 Compare August 2, 2023 07:32

guschmue previously approved these changes Aug 15, 2023

View reviewed changes

fs-eire reviewed Aug 16, 2023

View reviewed changes

js/web/lib/wasm/jsep/webgpu/ops/binary-op.ts Outdated Show resolved Hide resolved

fs-eire reviewed Aug 16, 2023

View reviewed changes

js/web/lib/wasm/jsep/webgpu/ops/binary-op.ts Outdated Show resolved Hide resolved

fs-eire reviewed Aug 16, 2023

View reviewed changes

js/web/lib/wasm/jsep/webgpu/ops/binary-op.ts Outdated Show resolved Hide resolved

xhcao dismissed guschmue’s stale review via 70f98c3 August 16, 2023 02:46

xhcao force-pushed the webgpu_typedbinary branch 2 times, most recently from 70f98c3 to 6958526 Compare August 16, 2023 02:48

xhcao force-pushed the webgpu_typedbinary branch from 6958526 to 7148392 Compare August 16, 2023 05:02

xhcao and others added 2 commits August 17, 2023 09:06

[js/web] Support int32 type for binary

e1df9a1

Co-authored-by: Xing Xu <xing.xu@intel.com>

Try manual cpplit

3c802a2

lintrunner passed in local, but bots failed duw to: onnxruntime/core/providers/js/operators/binary.cc:9: Lines should be <= 120 characters long [whitespace/line_length] [2]

xhcao force-pushed the webgpu_typedbinary branch from 7148392 to 3c802a2 Compare August 17, 2023 02:12

guschmue approved these changes Aug 18, 2023

View reviewed changes

fs-eire approved these changes Aug 18, 2023

View reviewed changes

fs-eire merged commit dd3b2ce into microsoft:main Aug 18, 2023

Conversation

xhcao commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

xhcao commented Jul 28, 2023

Uh oh!

qjia7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

guschmue commented Jul 28, 2023

Uh oh!

azure-pipelines bot commented Jul 28, 2023

Uh oh!

guschmue commented Jul 31, 2023

Uh oh!

Uh oh!

Uh oh!

axinging left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

guschmue commented Aug 1, 2023

Uh oh!

azure-pipelines bot commented Aug 1, 2023

Uh oh!

guschmue commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

axinging commented Aug 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fs-eire commented Aug 2, 2023

Uh oh!

azure-pipelines bot commented Aug 2, 2023

Uh oh!

guschmue commented Aug 2, 2023

Uh oh!

azure-pipelines bot commented Aug 2, 2023

Uh oh!

guschmue commented Aug 2, 2023

Uh oh!

azure-pipelines bot commented Aug 2, 2023

Uh oh!

guschmue commented Aug 2, 2023

Uh oh!

azure-pipelines bot commented Aug 2, 2023

Uh oh!

guschmue commented Aug 15, 2023

Uh oh!

azure-pipelines bot commented Aug 15, 2023

Uh oh!

guschmue commented Aug 15, 2023

Uh oh!

azure-pipelines bot commented Aug 15, 2023

Uh oh!

guschmue commented Aug 15, 2023

Uh oh!

azure-pipelines bot commented Aug 15, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fs-eire commented Aug 16, 2023

Uh oh!

azure-pipelines bot commented Aug 16, 2023

Uh oh!

fs-eire commented Aug 17, 2023

Uh oh!

azure-pipelines bot commented Aug 17, 2023

Uh oh!

guschmue commented Aug 17, 2023

Uh oh!

azure-pipelines bot commented Aug 17, 2023

Uh oh!

guschmue commented Aug 17, 2023

Uh oh!

xhcao commented Jul 28, 2023 •

edited

Loading

guschmue commented Aug 1, 2023 •

edited

Loading

axinging commented Aug 2, 2023 •

edited

Loading