Skip to content

Add API for updating TRT EP provider option user compute stream#16965

Merged
chilo-ms merged 7 commits intomainfrom
chi/trt_new_api
Aug 4, 2023
Merged

Add API for updating TRT EP provider option user compute stream#16965
chilo-ms merged 7 commits intomainfrom
chi/trt_new_api

Conversation

@chilo-ms
Copy link
Copy Markdown
Contributor

@chilo-ms chilo-ms commented Aug 1, 2023

Add a generic UpdateTensorRTProviderOptionsWithValue() C API to update TensorRT provider options where its data type is pointer that can't be represented by string.

@jywu-msft
Copy link
Copy Markdown
Member

jywu-msft commented Aug 2, 2023

Overall, it looks good. Thanks!
The only thing is i'm not sure the names of the new api is intuitive. UpdateTensorRTProviderOptionsWithUserComputeStream would better describe what it's doing, but the name would be way too long.
I'm ok with the name you selected if others agree with the naming convention.
Do we need to add an api for CUDA EP at the same time? can you coordinate with @hariharans29

@chilo-ms chilo-ms marked this pull request as ready for review August 2, 2023 17:51
@chilo-ms chilo-ms merged commit fc80033 into main Aug 4, 2023
@chilo-ms chilo-ms deleted the chi/trt_new_api branch August 4, 2023 22:14
chilo-ms added a commit that referenced this pull request Aug 9, 2023
)

Add a generic `UpdateCUDAProviderOptionsWithValue()` C API to update
CUDA EP provider options where its data type is pointer that can't be
represented by string.

Note: Please see some comments for the similar [PR
](#16965 TRT EP.
jchen351 pushed a commit that referenced this pull request Aug 12, 2023
Add a generic `UpdateTensorRTProviderOptionsWithValue()` C API to update
TensorRT provider options where its data type is pointer that can't be
represented by string.
jchen351 pushed a commit that referenced this pull request Aug 12, 2023
)

Add a generic `UpdateCUDAProviderOptionsWithValue()` C API to update
CUDA EP provider options where its data type is pointer that can't be
represented by string.

Note: Please see some comments for the similar [PR
](#16965 TRT EP.
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
…osoft#16965)

Add a generic `UpdateTensorRTProviderOptionsWithValue()` C API to update
TensorRT provider options where its data type is pointer that can't be
represented by string.
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
…rosoft#17037)

Add a generic `UpdateCUDAProviderOptionsWithValue()` C API to update
CUDA EP provider options where its data type is pointer that can't be
represented by string.

Note: Please see some comments for the similar [PR
](microsoft#16965 TRT EP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants