Skip to content

[JS/WebGPU] support Concat.int32 operator#17003

Merged
fs-eire merged 1 commit into
microsoft:mainfrom
xhcao:concat_int32
Sep 13, 2023
Merged

[JS/WebGPU] support Concat.int32 operator#17003
fs-eire merged 1 commit into
microsoft:mainfrom
xhcao:concat_int32

Conversation

@xhcao
Copy link
Copy Markdown
Contributor

@xhcao xhcao commented Aug 4, 2023

Description

Motivation and Context

@xhcao
Copy link
Copy Markdown
Contributor Author

xhcao commented Aug 4, 2023

@qjia7 @gyagp PTAL

qjia7
qjia7 reviewed Aug 4, 2023
View reviewed changes
Comment thread onnxruntime/core/providers/js/operators/concat.cc
@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Aug 7, 2023
@guschmue
Copy link
Copy Markdown
Contributor

guschmue commented Aug 12, 2023

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Aug 12, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Copy Markdown
Contributor

guschmue commented Aug 14, 2023

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Aug 14, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Copy Markdown
Contributor

guschmue commented Aug 14, 2023

lint is nagging:
Error: Following source files are not formatted: (did you run "npm run format"?)
js/web/lib/wasm/jsep/webgpu/ops/concat.ts

@xhcao
Copy link
Copy Markdown
Contributor Author

xhcao commented Aug 15, 2023

lint is nagging: Error: Following source files are not formatted: (did you run "npm run format"?) js/web/lib/wasm/jsep/webgpu/ops/concat.ts

Sorry for this error, I used npm run lint and did not throw any warning or error, and thought it had also checked the format.

@guschmue
Copy link
Copy Markdown
Contributor

guschmue commented Aug 15, 2023

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Aug 15, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Copy Markdown
Contributor

guschmue commented Aug 16, 2023

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Aug 16, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Copy Markdown
Contributor

guschmue commented Aug 16, 2023

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Aug 16, 2023

Azure Pipelines successfully started running 2 pipeline(s).

@xhcao
Copy link
Copy Markdown
Contributor Author

xhcao commented Aug 17, 2023

Removed the similar code as #17176.

@guschmue
Copy link
Copy Markdown
Contributor

guschmue commented Aug 18, 2023

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Aug 18, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@xhcao
Copy link
Copy Markdown
Contributor Author

xhcao commented Aug 23, 2023

Please take a look, thanks.

qjia7
qjia7 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guschmue @fs-eire Please take a look, thanks!

@guschmue
Copy link
Copy Markdown
Contributor

guschmue commented Aug 25, 2023

/azp run ONNX Runtime Web CI Pipeline

@guschmue
Copy link
Copy Markdown
Contributor

guschmue commented Aug 25, 2023

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Aug 25, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@guschmue
Copy link
Copy Markdown
Contributor

guschmue commented Aug 25, 2023

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Aug 25, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Aug 25, 2023

Azure Pipelines successfully started running 2 pipeline(s).

@xhcao
Copy link
Copy Markdown
Contributor Author

xhcao commented Sep 1, 2023

@fs-eire @guschmue @satyajandhyala Viewed the bots failures, it seemed that it was not related to the PR. Please trigger the bots to whether it could pass now.

@fs-eire
Copy link
Copy Markdown
Contributor

fs-eire commented Sep 11, 2023

/azp run Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline

@fs-eire
Copy link
Copy Markdown
Contributor

fs-eire commented Sep 11, 2023

/azp run Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-python-checks-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Sep 11, 2023

Azure Pipelines successfully started running 2 pipeline(s).

1 similar comment
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Sep 11, 2023

Azure Pipelines successfully started running 2 pipeline(s).

@fs-eire fs-eire merged commit ec94b07 into microsoft:main Sep 13, 2023
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
@xhcao @kleiti
[JS/WebGPU] support Concat.int32 operator (microsoft#17003)
264c3a3 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
@xhcao
[JS/WebGPU] support Concat.int32 operator (microsoft#17003)
977d4cf 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qjia7 qjia7 qjia7 approved these changes

+2 more reviewers

@satyajandhyala satyajandhyala satyajandhyala left review comments

@fs-eire fs-eire fs-eire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ep:WebGPU ort-web webgpu provider

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xhcao @guschmue @fs-eire @qjia7 @satyajandhyala