Eliminate hashmap copies during function inlining#17439
Merged
yuslepukhin merged 3 commits intomainfrom Sep 7, 2023
Merged
Conversation
yuslepukhin
commented
Sep 6, 2023
pranavsharma
reviewed
Sep 7, 2023
gramalingam
reviewed
Sep 7, 2023
Eliminate empty_map and pass nullptr as a default argument.
gramalingam
previously approved these changes
Sep 7, 2023
gramalingam
approved these changes
Sep 7, 2023
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
### Description Eliminate unnecessary HashMap copies. This saves 22% of CPU usage on a reference Dynamo exported model. ### Motivation and Context Our function inlining is currently slow. Before:  After 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Eliminate unnecessary HashMap copies. This saves 22% of CPU usage on a reference Dynamo exported model.
Motivation and Context
Our function inlining is currently slow.
Before:
After