Put the initializers at the end of the cluster inputs list#1751
Merged
jywu-msft merged 1 commit intomicrosoft:masterfrom Sep 3, 2019
Merged
Conversation
Restore the missing variable
Member
|
/azp run |
|
Azure Pipelines successfully started running 21 pipeline(s), but failed to run 1 pipeline(s). |
jywu-msft
approved these changes
Sep 3, 2019
yuslepukhin
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Describe your changes Use ONNX IR in graph surgeries to replace some proto manipulation. This PR adds a `call_ir` in the base class that is called when `__call__` is not overriden. This way the changes can be incremental and compatible with existing usages of the `Surgeon` class. Refactoring: - Renamed the Surgeon class that operates on proto to ProtoSurgeon to make the intention clear. Developers can subclass ProtoSurgeon to operate on proto and subclass Surgion to transform graphs directly with IR. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [x] Make sure all tests can pass. - [x] Update documents if necessary. - [x] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for the Reshape error which was observed when inferencing some models (for example YOLOv3). Only non-const inputs are required by the ngraph::Executable when it gets called and thus, during the partitioning phase, the initializers are placed at the end of the subgraph inputs. This makes it easier to map the tensors provided to the custom op to the ngraph::Executable inputs.