Fix some unnecessary copies of the Node attributes#1763
Merged
skottmckay merged 1 commit intomasterfrom Sep 6, 2019
Merged
Conversation
pranavsharma
reviewed
Sep 6, 2019
| if (attr.has_ref_attr_name()) { | ||
| if (attr_map.count(attr.ref_attr_name())) { | ||
| new_attr_map[attr.name()] = attr_map[attr.ref_attr_name()]; | ||
| auto entry = attr_map.find(attr.ref_attr_name()); |
Contributor
There was a problem hiding this comment.
curious: isn't count() achieving the same thing? (i wish stl had 'contains')
Contributor
Author
There was a problem hiding this comment.
In general, prefer 'find' over 'count' as the former will stop once it finds a match. Depending on the container type that can be a significant different.
Additionally in this case we want to use the entry, so 'count' + operator[] == two lookups vs one for using the iterator returned by 'find'.
pranavsharma
approved these changes
Sep 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Update a few places to not copy the Node attributes.
Motivation and Context
Copy is unnecessary expense.