-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[QNN EP] Integrate Resize op fixes from QNN 2.14.1 #17641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+308
−333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erent type (e.g., int64 shape/indices/etc)
Contributor
Author
|
@HectorSVC @jywu-msft |
adrianlizarraga
commented
Sep 20, 2023
onnxruntime/core/providers/qnn/builder/opbuilder/resize_op_builder.cc
Outdated
Show resolved
Hide resolved
adrianlizarraga
commented
Sep 20, 2023
…orners and add TODO in QNN EP tests. Add check for input shape and that only the spatial dimensions are resized.
HectorSVC
reviewed
Sep 21, 2023
…erly rejected) tests
adrianlizarraga
commented
Sep 22, 2023
onnxruntime/core/providers/qnn/builder/opbuilder/resize_op_builder.cc
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@HectorSVC @jywu-msft This is ready for your review when you're available please. |
HectorSVC
approved these changes
Sep 22, 2023
Contributor
HectorSVC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
### Description QNN SDK version 2.14.1 fixed several issues with the QNN Resize operator. This PR integrates the fixes and simplifies the implementation. ### Motivation and Context Improve Resize operator and test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QNN SDK version 2.14.1 fixed several issues with the QNN Resize operator. This PR integrates the fixes and simplifies the implementation.
Motivation and Context
Improve Resize operator and test coverage.